Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@suse.de>
To: Andrew Cagney <ac131313@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: m68k_register_virtual_type
Date: Fri, 22 Nov 2002 15:59:00 -0000	[thread overview]
Message-ID: <jehee988ay.fsf@sykes.suse.de> (raw)
In-Reply-To: <3DDE6120.4010205@redhat.com> (Andrew Cagney's message of "Fri, 22 Nov 2002 11:53:52 -0500")

Andrew Cagney <ac131313@redhat.com> writes:

|> Er, yes.  (And eventually long_double to builtin_type_m68881_ext but the
|> last one might have fallout related to register conversions).

I have now committed this patch.

Andreas.

2002-11-23  Andreas Schwab  <schwab@suse.de>

	* m68k-tdep.c (m68k_register_virtual_type): Use architecture
	invariant return values.

--- m68k-tdep.c.~1.28.~	2002-11-23 00:53:11.000000000 +0100
+++ m68k-tdep.c	2002-11-23 00:53:32.000000000 +0100
@@ -159,18 +159,19 @@ m68k_register_virtual_size (int regnum)
 static struct type *
 m68k_register_virtual_type (int regnum)
 {
-  if (regnum == E_FPI_REGNUM)
-    return lookup_pointer_type (builtin_type_void);
-  else if ((unsigned) regnum >= E_FPC_REGNUM)
-    return builtin_type_int;
-  else if ((unsigned) regnum >= FP0_REGNUM)
-    return builtin_type_long_double;
-  else if (regnum == PS_REGNUM)
-    return builtin_type_int;
-  else if ((unsigned) regnum >= A0_REGNUM)
-    return lookup_pointer_type (builtin_type_void);
-  else
-    return builtin_type_int;
+  if (regnum >= FP0_REGNUM && regnum <= FP0_REGNUM + 7)
+    return builtin_type_m68881_ext;
+
+  if (regnum == E_FPI_REGNUM || regnum == PC_REGNUM)
+    return builtin_type_void_func_ptr;
+
+  if (regnum == E_FPC_REGNUM || regnum == E_FPS_REGNUM || regnum == PS_REGNUM)
+    return builtin_type_int32;
+
+  if (regnum >= A0_REGNUM && regnum <= A0_REGNUM + 7)
+    return builtin_type_void_data_ptr;
+
+  return builtin_type_int32;
 }
 
 /* Function: m68k_register_name

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


  parent reply	other threads:[~2002-11-22 23:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-22  2:53 m68k_register_virtual_type Andreas Schwab
2002-11-22  7:33 ` m68k_register_virtual_type Andrew Cagney
2002-11-22  8:35   ` m68k_register_virtual_type Andreas Schwab
2002-11-22  8:54     ` m68k_register_virtual_type Andrew Cagney
2002-11-22  9:05       ` m68k_register_virtual_type Andreas Schwab
2002-11-22 15:59       ` Andreas Schwab [this message]
2002-11-22 16:25         ` m68k_register_virtual_type Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jehee988ay.fsf@sykes.suse.de \
    --to=schwab@suse.de \
    --cc=ac131313@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox