From: Andrew Cagney <ac131313@redhat.com>
To: Andreas Schwab <schwab@suse.de>
Cc: gdb-patches@sources.redhat.com
Subject: Re: m68k_register_virtual_type
Date: Fri, 22 Nov 2002 16:25:00 -0000 [thread overview]
Message-ID: <3DDECAE9.50203@redhat.com> (raw)
In-Reply-To: <jehee988ay.fsf@sykes.suse.de>
> |> Er, yes. (And eventually long_double to builtin_type_m68881_ext but the
> |> last one might have fallout related to register conversions).
>
> I have now committed this patch.
Thanks!
To answer your question. The m68k shouldn't have any fallout because
it's eliminated the CONVERT_FROM and CONVERT_TO methods (just never know
until someone tests it :-).
On the other hand, a target like the MIPS, which uses the convert
methods, could have problems. Those functions try to cover up GDB's
inability to manipulate floating point registers that had a non-standard
type. Fortunatly that inability has been fixed, just need to flush the
old code.
Andrew
> Andreas.
>
> 2002-11-23 Andreas Schwab <schwab@suse.de>
>
> * m68k-tdep.c (m68k_register_virtual_type): Use architecture
> invariant return values.
>
> --- m68k-tdep.c.~1.28.~ 2002-11-23 00:53:11.000000000 +0100
> +++ m68k-tdep.c 2002-11-23 00:53:32.000000000 +0100
> @@ -159,18 +159,19 @@ m68k_register_virtual_size (int regnum)
> static struct type *
> m68k_register_virtual_type (int regnum)
> {
> - if (regnum == E_FPI_REGNUM)
> - return lookup_pointer_type (builtin_type_void);
> - else if ((unsigned) regnum >= E_FPC_REGNUM)
> - return builtin_type_int;
> - else if ((unsigned) regnum >= FP0_REGNUM)
> - return builtin_type_long_double;
> - else if (regnum == PS_REGNUM)
> - return builtin_type_int;
> - else if ((unsigned) regnum >= A0_REGNUM)
> - return lookup_pointer_type (builtin_type_void);
> - else
> - return builtin_type_int;
> + if (regnum >= FP0_REGNUM && regnum <= FP0_REGNUM + 7)
> + return builtin_type_m68881_ext;
> +
prev parent reply other threads:[~2002-11-23 0:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-22 2:53 m68k_register_virtual_type Andreas Schwab
2002-11-22 7:33 ` m68k_register_virtual_type Andrew Cagney
2002-11-22 8:35 ` m68k_register_virtual_type Andreas Schwab
2002-11-22 8:54 ` m68k_register_virtual_type Andrew Cagney
2002-11-22 9:05 ` m68k_register_virtual_type Andreas Schwab
2002-11-22 15:59 ` m68k_register_virtual_type Andreas Schwab
2002-11-22 16:25 ` Andrew Cagney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DDECAE9.50203@redhat.com \
--to=ac131313@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox