From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19384 invoked by alias); 23 Nov 2002 00:25:20 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 19377 invoked from network); 23 Nov 2002 00:25:19 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 23 Nov 2002 00:25:19 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id C78303E4B; Fri, 22 Nov 2002 19:25:13 -0500 (EST) Message-ID: <3DDECAE9.50203@redhat.com> Date: Fri, 22 Nov 2002 16:25:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020824 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Andreas Schwab Cc: gdb-patches@sources.redhat.com Subject: Re: m68k_register_virtual_type References: <3DDE4E31.4010807@redhat.com> <3DDE6120.4010205@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-11/txt/msg00566.txt.bz2 > |> Er, yes. (And eventually long_double to builtin_type_m68881_ext but the > |> last one might have fallout related to register conversions). > > I have now committed this patch. Thanks! To answer your question. The m68k shouldn't have any fallout because it's eliminated the CONVERT_FROM and CONVERT_TO methods (just never know until someone tests it :-). On the other hand, a target like the MIPS, which uses the convert methods, could have problems. Those functions try to cover up GDB's inability to manipulate floating point registers that had a non-standard type. Fortunatly that inability has been fixed, just need to flush the old code. Andrew > Andreas. > > 2002-11-23 Andreas Schwab > > * m68k-tdep.c (m68k_register_virtual_type): Use architecture > invariant return values. > > --- m68k-tdep.c.~1.28.~ 2002-11-23 00:53:11.000000000 +0100 > +++ m68k-tdep.c 2002-11-23 00:53:32.000000000 +0100 > @@ -159,18 +159,19 @@ m68k_register_virtual_size (int regnum) > static struct type * > m68k_register_virtual_type (int regnum) > { > - if (regnum == E_FPI_REGNUM) > - return lookup_pointer_type (builtin_type_void); > - else if ((unsigned) regnum >= E_FPC_REGNUM) > - return builtin_type_int; > - else if ((unsigned) regnum >= FP0_REGNUM) > - return builtin_type_long_double; > - else if (regnum == PS_REGNUM) > - return builtin_type_int; > - else if ((unsigned) regnum >= A0_REGNUM) > - return lookup_pointer_type (builtin_type_void); > - else > - return builtin_type_int; > + if (regnum >= FP0_REGNUM && regnum <= FP0_REGNUM + 7) > + return builtin_type_m68881_ext; > +