From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6276 invoked by alias); 22 Nov 2002 23:59:55 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6269 invoked from network); 22 Nov 2002 23:59:54 -0000 Received: from unknown (HELO Cantor.suse.de) (213.95.15.193) by sources.redhat.com with SMTP; 22 Nov 2002 23:59:54 -0000 Received: from Hermes.suse.de (Charybdis.suse.de [213.95.15.201]) by Cantor.suse.de (Postfix) with ESMTP id 56ECD14BAD; Sat, 23 Nov 2002 00:59:54 +0100 (MET) X-Authentication-Warning: sykes.suse.de: schwab set sender to schwab@suse.de using -f To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: m68k_register_virtual_type References: <3DDE4E31.4010807@redhat.com> <3DDE6120.4010205@redhat.com> X-Yow: I wonder if there's anything GOOD on tonight? From: Andreas Schwab Date: Fri, 22 Nov 2002 15:59:00 -0000 In-Reply-To: <3DDE6120.4010205@redhat.com> (Andrew Cagney's message of "Fri, 22 Nov 2002 11:53:52 -0500") Message-ID: User-Agent: Gnus/5.090007 (Oort Gnus v0.07) Emacs/21.3.50 (ia64-suse-linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-SW-Source: 2002-11/txt/msg00565.txt.bz2 Andrew Cagney writes: |> Er, yes. (And eventually long_double to builtin_type_m68881_ext but the |> last one might have fallout related to register conversions). I have now committed this patch. Andreas. 2002-11-23 Andreas Schwab * m68k-tdep.c (m68k_register_virtual_type): Use architecture invariant return values. --- m68k-tdep.c.~1.28.~ 2002-11-23 00:53:11.000000000 +0100 +++ m68k-tdep.c 2002-11-23 00:53:32.000000000 +0100 @@ -159,18 +159,19 @@ m68k_register_virtual_size (int regnum) static struct type * m68k_register_virtual_type (int regnum) { - if (regnum == E_FPI_REGNUM) - return lookup_pointer_type (builtin_type_void); - else if ((unsigned) regnum >= E_FPC_REGNUM) - return builtin_type_int; - else if ((unsigned) regnum >= FP0_REGNUM) - return builtin_type_long_double; - else if (regnum == PS_REGNUM) - return builtin_type_int; - else if ((unsigned) regnum >= A0_REGNUM) - return lookup_pointer_type (builtin_type_void); - else - return builtin_type_int; + if (regnum >= FP0_REGNUM && regnum <= FP0_REGNUM + 7) + return builtin_type_m68881_ext; + + if (regnum == E_FPI_REGNUM || regnum == PC_REGNUM) + return builtin_type_void_func_ptr; + + if (regnum == E_FPC_REGNUM || regnum == E_FPS_REGNUM || regnum == PS_REGNUM) + return builtin_type_int32; + + if (regnum >= A0_REGNUM && regnum <= A0_REGNUM + 7) + return builtin_type_void_data_ptr; + + return builtin_type_int32; } /* Function: m68k_register_name -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."