From: Andreas Schwab <schwab@suse.de>
To: "Maciej W. Rozycki" <macro@mips.com>
Cc: gdb-patches@sourceware.org, Nigel Stephens <nigel@mips.com>,
"Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: mips-tdep.c: FP varargs fixes
Date: Fri, 23 Mar 2007 14:53:00 -0000 [thread overview]
Message-ID: <jefy7wdna8.fsf@sykes.suse.de> (raw)
In-Reply-To: <Pine.LNX.4.61.0703231339070.6921@perivale.mips.com> (Maciej W. Rozycki's message of "Fri, 23 Mar 2007 14:41:16 +0000 (GMT)")
"Maciej W. Rozycki" <macro@mips.com> writes:
> @@ -3272,7 +3283,7 @@
> /* Write this portion of the argument to a general
> purpose register. */
> if (argreg <= MIPS_LAST_ARG_REGNUM
> - && !fp_register_arg_p (typecode, arg_type))
> + /*&& !fp_register_arg_p (typecode, arg_type)*/)
Please don't comment out code, remove it instead, and add a comment why it
was removed.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
prev parent reply other threads:[~2007-03-23 14:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-23 14:41 Maciej W. Rozycki
2007-03-23 14:51 ` Mark Kettenis
2007-03-26 16:00 ` Maciej W. Rozycki
2007-04-10 15:44 ` Daniel Jacobowitz
2007-04-17 14:56 ` Maciej W. Rozycki
2007-04-17 15:00 ` Daniel Jacobowitz
2007-04-17 16:05 ` Maciej W. Rozycki
2007-04-17 16:26 ` Daniel Jacobowitz
2007-04-17 20:52 ` Michael Snyder
2007-04-18 9:59 ` Maciej W. Rozycki
2007-03-23 14:53 ` Andreas Schwab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jefy7wdna8.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=macro@linux-mips.org \
--cc=macro@mips.com \
--cc=nigel@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox