Re: mips-tdep.c: FP varargs fixes

[Daniel Jacobowitz <drow@false.org>]

On Mon, Mar 26, 2007 at 05:00:01PM +0100, Maciej W. Rozycki wrote:
>  This new patch has been tested natively for mips-unknown-linux-gnu and 
> remotely for mipsisa32-sde-elf, using mips-sim-sde32/-EB and 
> mips-sim-sde32/-EL as the targets.

If you really want to build up some bonus points, you could extend the
argument passing testcases to trigger some of these cases :-)

> 2007-03-26  Maciej W. Rozycki  <macro@mips.com>
>             Nigel Stephens  <nigel@mips.com>
> 
> 	* mips-tdep.c (mips_o32_push_dummy_call): Take account of
> 	argument alignment requirements when calculating stack space
> 	required.  When aligning an arg register to eight bytes
> 	boundary, align stack_offset too.  Write floating-point
> 	arguments to the appropriate integer register if need go there.
> 	(mips_o64_push_dummy_call): Likewise.
> 
>  It looks like the calls to mips_abi_regsize() within are now redundant in 
> these functions, because the result is implied by the very fact of calling 
> either of these functions, but this is functionally independent from this 
> change so I think it should be dealt with separately.

I agree.

>  OK to apply?

Yes, this is OK.  I'll just trust you on the underlying ABI issues,
since you know it better than I do.  It all looks sane.

-- 
Daniel Jacobowitz
CodeSourcery