From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31695 invoked by alias); 10 Apr 2007 15:44:44 -0000 Received: (qmail 31686 invoked by uid 22791); 10 Apr 2007 15:44:43 -0000 X-Spam-Check-By: sourceware.org Received: from return.false.org (HELO return.false.org) (66.207.162.98) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 10 Apr 2007 16:44:37 +0100 Received: from return.false.org (localhost [127.0.0.1]) by return.false.org (Postfix) with ESMTP id 18F354B267; Tue, 10 Apr 2007 10:44:36 -0500 (CDT) Received: from caradoc.them.org (dsl093-172-095.pit1.dsl.speakeasy.net [66.93.172.95]) by return.false.org (Postfix) with ESMTP id 5DF4D4B262; Tue, 10 Apr 2007 10:44:31 -0500 (CDT) Received: from drow by caradoc.them.org with local (Exim 4.63) (envelope-from ) id 1HbIWE-0003S7-8X; Tue, 10 Apr 2007 11:44:30 -0400 Date: Tue, 10 Apr 2007 15:44:00 -0000 From: Daniel Jacobowitz To: "Maciej W. Rozycki" Cc: Mark Kettenis , gdb-patches@sourceware.org, Nigel Stephens , "Maciej W. Rozycki" Subject: Re: mips-tdep.c: FP varargs fixes Message-ID: <20070410154430.GG10890@caradoc.them.org> Mail-Followup-To: "Maciej W. Rozycki" , Mark Kettenis , gdb-patches@sourceware.org, Nigel Stephens , "Maciej W. Rozycki" References: <200703231449.l2NEnQSb031165@brahms.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-04/txt/msg00092.txt.bz2 On Mon, Mar 26, 2007 at 05:00:01PM +0100, Maciej W. Rozycki wrote: > This new patch has been tested natively for mips-unknown-linux-gnu and > remotely for mipsisa32-sde-elf, using mips-sim-sde32/-EB and > mips-sim-sde32/-EL as the targets. If you really want to build up some bonus points, you could extend the argument passing testcases to trigger some of these cases :-) > 2007-03-26 Maciej W. Rozycki > Nigel Stephens > > * mips-tdep.c (mips_o32_push_dummy_call): Take account of > argument alignment requirements when calculating stack space > required. When aligning an arg register to eight bytes > boundary, align stack_offset too. Write floating-point > arguments to the appropriate integer register if need go there. > (mips_o64_push_dummy_call): Likewise. > > It looks like the calls to mips_abi_regsize() within are now redundant in > these functions, because the result is implied by the very fact of calling > either of these functions, but this is functionally independent from this > change so I think it should be dealt with separately. I agree. > OK to apply? Yes, this is OK. I'll just trust you on the underlying ABI issues, since you know it better than I do. It all looks sane. -- Daniel Jacobowitz CodeSourcery