From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27616 invoked by alias); 23 Mar 2007 14:53:26 -0000 Received: (qmail 27608 invoked by uid 22791); 23 Mar 2007 14:53:25 -0000 X-Spam-Check-By: sourceware.org Received: from ns1.suse.de (HELO mx1.suse.de) (195.135.220.2) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 23 Mar 2007 14:53:22 +0000 Received: from Relay2.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.suse.de (Postfix) with ESMTP id A1DA512367; Fri, 23 Mar 2007 15:53:20 +0100 (CET) From: Andreas Schwab To: "Maciej W. Rozycki" Cc: gdb-patches@sourceware.org, Nigel Stephens , "Maciej W. Rozycki" Subject: Re: mips-tdep.c: FP varargs fixes References: X-Yow: I will invent "TIDY BOWL"... Date: Fri, 23 Mar 2007 14:53:00 -0000 In-Reply-To: (Maciej W. Rozycki's message of "Fri, 23 Mar 2007 14:41:16 +0000 (GMT)") Message-ID: User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-03/txt/msg00208.txt.bz2 "Maciej W. Rozycki" writes: > @@ -3272,7 +3283,7 @@ > /* Write this portion of the argument to a general > purpose register. */ > if (argreg <= MIPS_LAST_ARG_REGNUM > - && !fp_register_arg_p (typecode, arg_type)) > + /*&& !fp_register_arg_p (typecode, arg_type)*/) Please don't comment out code, remove it instead, and add a comment why it was removed. Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."