Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@suse.de>
To: Tom Tromey <tromey@redhat.com>
Cc: Joel Brobecker <brobecker@adacore.com>, 	gdb-patches@sourceware.org
Subject: Re: RFA: shrink main_type
Date: Mon, 18 Aug 2008 22:17:00 -0000	[thread overview]
Message-ID: <jefxp2hste.fsf@sykes.suse.de> (raw)
In-Reply-To: <m38wuuw1tz.fsf@fleche.redhat.com> (Tom Tromey's message of "Mon, 	18 Aug 2008 13:38:32 -0600")

Tom Tromey <tromey@redhat.com> writes:

> +  /* Copy the common fields of types.  For the main type, we simply
> +     copy the entire thing and then update specific fields as needed.  */
> +  memcpy (TYPE_MAIN_TYPE (new_type), TYPE_MAIN_TYPE (type),
> +	  sizeof (struct main_type));

IMHO this should be written as an assignment.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


  reply	other threads:[~2008-08-18 22:17 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-17 18:50 Tom Tromey
2008-08-18 13:01 ` Joel Brobecker
2008-08-18 13:20   ` Daniel Jacobowitz
2008-08-18 13:30     ` Joel Brobecker
2008-08-18 15:19     ` Tom Tromey
2008-08-18 19:39       ` Tom Tromey
2008-08-18 22:17         ` Andreas Schwab [this message]
2008-08-18 22:32           ` Daniel Jacobowitz
2008-08-19  5:13         ` Joel Brobecker
2008-08-19 17:56           ` Tom Tromey
2008-08-24 10:12             ` Joel Brobecker
2008-08-24 16:41               ` Tom Tromey
2008-08-24 18:03                 ` Tom Tromey
2008-08-24 20:35                   ` Tom Tromey
2008-08-25 15:50                     ` Joel Brobecker
2008-08-25 19:12                       ` Tom Tromey
2010-09-15 19:23             ` Ken Werner
2010-09-25 14:38               ` Ken Werner
2010-09-30 18:56               ` Joel Brobecker
2010-10-01 13:23                 ` Ken Werner
2010-10-01 15:34                 ` [patch] move the nottext flag to the instance_flags Ken Werner
2010-10-01 16:15                   ` Joel Brobecker
2010-10-05 21:50                     ` Tom Tromey
2010-10-06  8:45                       ` Ken Werner
2008-08-18 15:04   ` RFA: shrink main_type Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jefxp2hste.fsf@sykes.suse.de \
    --to=schwab@suse.de \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox