Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Ken Werner <ken@linux.vnet.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] move the nottext flag to the instance_flags
Date: Fri, 01 Oct 2010 16:15:00 -0000	[thread overview]
Message-ID: <20101001161524.GE6213@adacore.com> (raw)
In-Reply-To: <201010011734.34087.ken@linux.vnet.ibm.com>

> 2010-10-01  Ken Werner  <ken.werner@de.ibm.com>
> 
> 	* gdbtypes.h (struct main_type): Remove flag_nottext.
> 	(enum type_flag_value): Remove TYPE_FLAG_NOTTEXT.
> 	(enum type_instance_flag_value): Add TYPE_INSTANCE_FLAG_NOTTEXT.
> 	(TYPE_NOTTEXT): Use TYPE_INSTANCE_FLAG_NOTTEXT instead of flag_nottext.
> 	* gdbtypes.c (make_vector_type): Use TYPE_INSTANCE_FLAG_NOTTEXT instead
> 	of TYPE_FLAG_NOTTEXT.
> 	(init_type): Remove the initialization of the flag_nottext field.
> 	(gdbtypes_post_init): Use TYPE_INSTANCE_FLAG_NOTTEXT instead of
> 	TYPE_FLAG_NOTTEXT.
> 	* c-valprint.c (c_val_print): Remove TYPE_VECTOR check.
> 
> testsuite/ChangeLog:
> 
> 2010-10-01  Ken Werner  <ken.werner@de.ibm.com>
> 
> 	* gdb.base/gnu_vector.c: Add variable c4.
> 	* gdb.base/gnu_vector.exp: Add tests for character vector printing.
> 	* gdb.arch/altivec-abi.exp: Fix expect pattern of character vectors.

Looks good to me. Can you wait, maybe a day or two to give Tom a chance
to comment before you commit, in case he spots something I didn't?

Thanks,
-- 
Joel


  reply	other threads:[~2010-10-01 16:15 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-17 18:50 RFA: shrink main_type Tom Tromey
2008-08-18 13:01 ` Joel Brobecker
2008-08-18 13:20   ` Daniel Jacobowitz
2008-08-18 13:30     ` Joel Brobecker
2008-08-18 15:19     ` Tom Tromey
2008-08-18 19:39       ` Tom Tromey
2008-08-18 22:17         ` Andreas Schwab
2008-08-18 22:32           ` Daniel Jacobowitz
2008-08-19  5:13         ` Joel Brobecker
2008-08-19 17:56           ` Tom Tromey
2008-08-24 10:12             ` Joel Brobecker
2008-08-24 16:41               ` Tom Tromey
2008-08-24 18:03                 ` Tom Tromey
2008-08-24 20:35                   ` Tom Tromey
2008-08-25 15:50                     ` Joel Brobecker
2008-08-25 19:12                       ` Tom Tromey
2010-09-15 19:23             ` Ken Werner
2010-09-25 14:38               ` Ken Werner
2010-09-30 18:56               ` Joel Brobecker
2010-10-01 13:23                 ` Ken Werner
2010-10-01 15:34                 ` [patch] move the nottext flag to the instance_flags Ken Werner
2010-10-01 16:15                   ` Joel Brobecker [this message]
2010-10-05 21:50                     ` Tom Tromey
2010-10-06  8:45                       ` Ken Werner
2008-08-18 15:04   ` RFA: shrink main_type Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101001161524.GE6213@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=ken@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox