From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13043 invoked by alias); 1 Oct 2010 16:15:38 -0000 Received: (qmail 13003 invoked by uid 22791); 1 Oct 2010 16:15:35 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 01 Oct 2010 16:15:31 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 2F3382BACA2; Fri, 1 Oct 2010 12:15:28 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 8ig4x370Beiv; Fri, 1 Oct 2010 12:15:28 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id EE6472BAC9D; Fri, 1 Oct 2010 12:15:27 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 08B95F591F; Fri, 1 Oct 2010 09:15:24 -0700 (PDT) Date: Fri, 01 Oct 2010 16:15:00 -0000 From: Joel Brobecker To: Ken Werner Cc: gdb-patches@sourceware.org Subject: Re: [patch] move the nottext flag to the instance_flags Message-ID: <20101001161524.GE6213@adacore.com> References: <201009151441.43723.ken@linux.vnet.ibm.com> <20100930175518.GA2976@adacore.com> <201010011734.34087.ken@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201010011734.34087.ken@linux.vnet.ibm.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-10/txt/msg00008.txt.bz2 > 2010-10-01 Ken Werner > > * gdbtypes.h (struct main_type): Remove flag_nottext. > (enum type_flag_value): Remove TYPE_FLAG_NOTTEXT. > (enum type_instance_flag_value): Add TYPE_INSTANCE_FLAG_NOTTEXT. > (TYPE_NOTTEXT): Use TYPE_INSTANCE_FLAG_NOTTEXT instead of flag_nottext. > * gdbtypes.c (make_vector_type): Use TYPE_INSTANCE_FLAG_NOTTEXT instead > of TYPE_FLAG_NOTTEXT. > (init_type): Remove the initialization of the flag_nottext field. > (gdbtypes_post_init): Use TYPE_INSTANCE_FLAG_NOTTEXT instead of > TYPE_FLAG_NOTTEXT. > * c-valprint.c (c_val_print): Remove TYPE_VECTOR check. > > testsuite/ChangeLog: > > 2010-10-01 Ken Werner > > * gdb.base/gnu_vector.c: Add variable c4. > * gdb.base/gnu_vector.exp: Add tests for character vector printing. > * gdb.arch/altivec-abi.exp: Fix expect pattern of character vectors. Looks good to me. Can you wait, maybe a day or two to give Tom a chance to comment before you commit, in case he spots something I didn't? Thanks, -- Joel