From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-58079-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 2107 invoked by alias); 18 Aug 2008 22:17:45 -0000
Received: (qmail 2096 invoked by uid 22791); 18 Aug 2008 22:17:45 -0000
X-Spam-Check-By: sourceware.org
Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 18 Aug 2008 22:17:04 +0000
Received: from Relay2.suse.de (mail2.suse.de [195.135.221.8]) 	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) 	(No client certificate requested) 	by mx2.suse.de (Postfix) with ESMTP id 4B89E45D9D; 	Tue, 19 Aug 2008 00:17:02 +0200 (CEST)
From: Andreas Schwab <schwab@suse.de>
To: Tom Tromey <tromey@redhat.com>
Cc: Joel Brobecker <brobecker@adacore.com>, 	gdb-patches@sourceware.org
Subject: Re: RFA: shrink main_type
References: <m37iafzdcp.fsf@fleche.redhat.com> 	<20080818130009.GM16894@adacore.com> 	<20080818132001.GA9434@caradoc.them.org> 	<m3ej4mxshs.fsf@fleche.redhat.com> <m38wuuw1tz.fsf@fleche.redhat.com>
X-Yow: Yow!  Those people look exactly like Donnie and Marie Osmond!!
Date: Mon, 18 Aug 2008 22:17:00 -0000
In-Reply-To: <m38wuuw1tz.fsf@fleche.redhat.com> (Tom Tromey's message of "Mon, 	18 Aug 2008 13:38:32 -0600")
Message-ID: <jefxp2hste.fsf@sykes.suse.de>
User-Agent: Gnus/5.110009 (No Gnus v0.9) Emacs/22.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-08/txt/msg00502.txt.bz2

Tom Tromey <tromey@redhat.com> writes:

> +  /* Copy the common fields of types.  For the main type, we simply
> +     copy the entire thing and then update specific fields as needed.  */
> +  memcpy (TYPE_MAIN_TYPE (new_type), TYPE_MAIN_TYPE (type),
> +	  sizeof (struct main_type));

IMHO this should be written as an assignment.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."