Re: [PATCH] [PR corefiles/32441] Fix segfault if target_fileio_read_alloc fails

[Brandon Belew <brandon.belew@zetier.com>]

Thank you Luis for reviewing and responding to my comments in IRC! Just a few
more questions: 

Luis Machado <luis.machado@arm.com> writes:
> On 12/20/24 22:17, brandon.belew wrote:
>> Check for target_fileio_read_alloc failure in linux_fill_prpsinfo
>> before dereferencing buffer. This fixes a segfault in the 'gcore'
>> command when attached to certain remote targets.
>> ---
>> This is my first contribution to GDB, and my first use of
>> git-send-email, so please let me know if this is formatted
>> incorrectly! I initially submitted the bug and a v1 patch at
>> https://sourceware.org/bugzilla/show_bug.cgi?id=32441 and received the
>> following from Thiago Bauermann:
>
> Formatting-wise, The commit message goes into the patch itself. See other examples
> on the list.

It was my understanding of git-format-patch / git-send-email (and in
reverse, git-am) that the commit message would be taken from everything
up to the '---'. Then everything between the '---' and the actual diff
was considered "timely commentary" and would not be present in the
commit message. This typically contains the diffstat output but also is
used for commentary on the patch that shouldn't go into the commit
itself.

As described in https://git-scm.com/docs/git-format-patch:
> Typically it will be placed in a MUA’s drafts folder, edited to add
> timely commentary that should not go in the changelog ***after the
> three dashes*** [emphasis added] 

And also as described at
https://spacekookie.de/blog/collaborating-with-git-send-email/:
> Another often overlooked feature here is "timely commentary", are
> comments in the patch e-mail that won't be part of the patch or the
> commit message itself. They can be made after the --- marker in a
> patch mail, but before the actual patch starts. This section is
> usually used for the diff-stat of that particular patch.

I tried sending the patch email to myself before I sent it to the list,
piping it to `git-am`, and it correctly applied the commit without my
"timely commentary", so I was pretty convinced I had formatted it
correctly.

Do you get something different when you `git am` my message? If so, can
you be more specific about how I need to reformat the email?

> Also, since you've opened a bug, we have hooks to refer to the bug. For instance,
> for commit ca263aec20adfffe6f9dab3a18f8a7b24667f99c.
>
> PR testsuite/32489
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=32489

I'm confused about this - are you asking or suggesting that I format my
message in a different way to take advantage of these hooks? Where are
the hooks applied? 

> The change itself looks OK to me. I'd like another pair of eyes to look at
> it before we approve it. I think this can go in as a trivial change when it
> gets approved.
>
> Reviewed-By: Luis Machado <luis.machado@arm.com>

Thank again for your review and help! 

   ~Brandon