Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: Brandon Belew <brandon.belew@zetier.com>,
	gdb-patches@sourceware.org,
	Joel Brobecker <brobecker@adacore.com>
Subject: Re: [PATCH v2] [PR corefiles/32441] Fix segfault if target_fileio_read_alloc fails
Date: Sun, 9 Mar 2025 08:17:32 +0400	[thread overview]
Message-ID: <Z80WXOal0byi9h7U@adacore.com> (raw)
In-Reply-To: <87ikouz5ys.fsf@redhat.com>

> > Check for target_fileio_read_alloc failure in linux_fill_prpsinfo
> > before dereferencing buffer. This fixes a segfault in the 'gcore'
> > command when attached to certain remote targets.
> 
> LGTM.
> 
> Approved-By: Andrew Burgess <aburgess@redhat.com>

Thank you Andrew. Brandon reached out privately saying he does not have
push access, and so I pushed the patch for him.

Tom also approved in a different thread (about the gdb 16.3 release
status) the backport to the gdb-16-branch, so I will do that next.

-- 
Joel

  parent reply	other threads:[~2025-03-09  4:18 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-20 22:17 [PATCH] " brandon.belew
2025-01-16 10:27 ` Luis Machado
2025-01-16 16:28   ` Brandon Belew
2025-01-16 16:51 ` Andrew Burgess
2025-01-16 17:36   ` Brandon Belew
2025-01-20 14:44     ` Andrew Burgess
2025-01-27 20:20   ` [PATCH v2] " Brandon Belew
2025-02-18 23:44     ` Brandon Belew
2025-02-28 11:03     ` Andrew Burgess
2025-03-04 13:47       ` [PATCH v3] " Brandon Belew
2025-03-09  4:17       ` Joel Brobecker [this message]
2025-03-01 10:23 GDB 16.3 release - 2025-03-01 update Joel Brobecker
2025-03-03 14:23 ` Luis Machado
2025-03-04  3:07   ` Joel Brobecker
2025-03-03 15:08 ` Brandon Belew
2025-03-04  3:12   ` Joel Brobecker
2025-03-07 14:07     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z80WXOal0byi9h7U@adacore.com \
    --to=brobecker@adacore.com \
    --cc=aburgess@redhat.com \
    --cc=brandon.belew@zetier.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox