From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id LG+fOYEWzWcymwkAWB0awg (envelope-from ) for ; Sat, 08 Mar 2025 23:18:09 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=hcSCEZRO; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id CD60D1E105; Sat, 8 Mar 2025 23:18:09 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D5EB51E05C for ; Sat, 8 Mar 2025 23:18:08 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0D9263858D38 for ; Sun, 9 Mar 2025 04:18:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0D9263858D38 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=hcSCEZRO Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by sourceware.org (Postfix) with ESMTPS id B63173858D33 for ; Sun, 9 Mar 2025 04:17:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B63173858D33 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B63173858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::32c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1741493858; cv=none; b=aeLaaYkr1qZjdCRJB/4JYTipTrQuG4zD75xoej6k/JQN8RK01AIhJYWfiM3rJKT2VxGdXPj3mqOCYfK/ixeZPjF6A7/PDHB+8W0nAuOm8MFU8HtvW8vpO63hkPdJ5q2l2h9gyC2dPpONiKkqVaT4KadaUFP65/CULd2utB5/YyY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1741493858; c=relaxed/simple; bh=AHKKTvkPVBHfWifSoVLiy6Oa61dhP5L27HglYqy3x0A=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=D11P4svGYHbtZbS5LLZmjK2l9+j8ml77PltUn0N0amILXQWbwEbNf1Pm6GeXsci39R6YX7B6rezScnN9tL9W/u8NqPW6NTfIVjPV4oKKhh1zHN5hX5RTaoeesf4TlHYGnLSInW8tsCV3Mzoo0pmlrdVId2KwVL+BuGw4MQF54+A= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B63173858D33 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-4393dc02b78so18386135e9.3 for ; Sat, 08 Mar 2025 20:17:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1741493856; x=1742098656; darn=sourceware.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0qs16Df0Dk1Q/077KRvgDY36esi9RSnV/LjKbuiMw6U=; b=hcSCEZRO/N95unQgskgdWjsc3ANFCbOVI2lm9gxnoBMp4VVGk7bGIStBjwPeZX1sj1 E+2YQ7eQnJvXypXrngon68VejXl/jo7dHD6RGrUjruKfeUp1yYU1V5CqCnANBSjURtzu C2riRc6UWayEiidtZEbBRdqhZ77qAIE/2bNWsGUXGjTGugOVDBfMHgAMuiP4fb7+1m/R ROk3bsOOpHfZLK7KDOwgEMR0qWdOPlXF4cyKjeEGWiYJ2Z/8HR7yflK2wFInPkvSAPO8 xhVyUukQzlpNVZJaMYpa4XidRl5BLjlmSKJjv29epSS8H9sEDmMjuPFQrWbbHzq5QHb5 AJag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741493856; x=1742098656; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0qs16Df0Dk1Q/077KRvgDY36esi9RSnV/LjKbuiMw6U=; b=ODwAb67xvUvEZ/rxCts37k0Cl2TIaMAmMFqvxMqh8V5FJy/l5STLXRdOHpPoJsM8tY /dVxLLad4S3bAo6B1YbVSKYJOYV3oA8SO/Lp5Isb3fENnuKGJuoeFKyEF4U5cBOGUBrs RVOB93JEwqRfXDL9c0/ETp8yiVkQ7LPX78kvuX4GnTNkU48fJVVp0iMovXx9rQyUcFZX BD7QtOPe0oGEz7OcRnNXwof9zaMhdxW7uJxq/Rxm8sepkTzPuFsUyiF5XYmKHyXNjGad uZJr23FDkQLUIBzKFqnVnRY0Me5pRCe34dsw1AF+eRg6kYZZAQTVB1GslfPGCGisCavc 1QAA== X-Forwarded-Encrypted: i=1; AJvYcCXI3WH+SN2CEJHbCrxWjwDLCmGoLokaYFvqiOnLmke8MtMwq4MLEbUBJfODavMWHrnjDCekDgZtKNg64g==@sourceware.org X-Gm-Message-State: AOJu0YwMKsmOWZyR9a9XWIs+toOtqE6baiEEfvftLPvdhWFNcz4WxObH 2zts7If1ZdiG3BOafRghjblCPmQLFB7UD7ytPdfhGrGPu84BhWgMnOHc2dXm X-Gm-Gg: ASbGnctD1CsbLFFhDDv02mCzgBreH3V7GWtPf2H1rZCmdYk43bTYwBDZ8jxyMeKC+p4 UrnKm8LuRlTZ3LZ+RhBpskCux9v3l6zKwE3nM0Wec0HBGtIqJoq3Vk4ty7DjJoiwjQNvSy2XXyJ SO88sKJ32vdsP36/fS0UUYBt8GH7j/c2isrdXmjhRw3yJ3vvtZFhe1EK8UvhdPtMhvZ7hMNrdCS zbWV0iWtlK24XgxhzsnoMPKloanYNU56VVt6Pa8ewYaBltbvzezsImLhg/oHSg+fZmuIpIH0Wgd b1qySlpbukR5WYUj288Z3QvoBDD0Xyz58WCMDV00/PWHr9N5nJsyup6rPBS9GvuM0SY5Dky9xco PnWgvnnFJuSxfT+6hz00M X-Google-Smtp-Source: AGHT+IFCIF7PhI+TW92TG8rntcuXE4157Z8cPQ9OF5Dad8TgpZFiULp23C2X9XBg+EUWMFt/tTSAiA== X-Received: by 2002:a05:600c:5108:b0:43b:c0fa:f9dd with SMTP id 5b1f17b1804b1-43c5c6a4137mr48269375e9.25.1741493856379; Sat, 08 Mar 2025 20:17:36 -0800 (PST) Received: from takamaka.gnat.com (lfbn-reu-1-488-54.w92-130.abo.wanadoo.fr. [92.130.77.54]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ce5c35709sm45214755e9.19.2025.03.08.20.17.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Mar 2025 20:17:35 -0800 (PST) Received: by takamaka.gnat.com (Postfix, from userid 1000) id ED4478065C; Sun, 9 Mar 2025 08:17:32 +0400 (+04) Date: Sun, 9 Mar 2025 08:17:32 +0400 From: Joel Brobecker To: Andrew Burgess Cc: Brandon Belew , gdb-patches@sourceware.org, Joel Brobecker Subject: Re: [PATCH v2] [PR corefiles/32441] Fix segfault if target_fileio_read_alloc fails Message-ID: References: <87v7ueog73.fsf@redhat.com> <87ikouz5ys.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ikouz5ys.fsf@redhat.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > > Check for target_fileio_read_alloc failure in linux_fill_prpsinfo > > before dereferencing buffer. This fixes a segfault in the 'gcore' > > command when attached to certain remote targets. > > LGTM. > > Approved-By: Andrew Burgess Thank you Andrew. Brandon reached out privately saying he does not have push access, and so I pushed the patch for him. Tom also approved in a different thread (about the gdb 16.3 release status) the backport to the gdb-16-branch, so I will do that next. -- Joel