From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gGmaNak1iWeQRhEAWB0awg (envelope-from ) for ; Thu, 16 Jan 2025 11:36:57 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=zetier.com header.i=@zetier.com header.a=rsa-sha256 header.s=gm header.b=RWtnFY1c; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D50CC1E100; Thu, 16 Jan 2025 11:36:57 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 945491E05C for ; Thu, 16 Jan 2025 11:36:56 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3EA0B384DEF5 for ; Thu, 16 Jan 2025 16:36:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3EA0B384DEF5 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=zetier.com header.i=@zetier.com header.a=rsa-sha256 header.s=gm header.b=RWtnFY1c Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) by sourceware.org (Postfix) with ESMTPS id 24B29384DEE0 for ; Thu, 16 Jan 2025 16:28:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 24B29384DEE0 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=zetier.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=zetier.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 24B29384DEE0 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::735 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737044921; cv=none; b=qILIrp2clS4xeRx1dWXP4MtSGVJpDlWi9zL5pJcgMI81IH14Ev2OatmOdDOn+yDjgc/sP0p/TfiqwVIA1ZmPKEr6P9YsgrC9xh3NOS5pau4TPzyI2IhXcS1rWxW/h1pWB8UDsIYsRG020vUkVTmip2QySYhiGq6f4pvqwypPumc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737044921; c=relaxed/simple; bh=GFqgkGULRiY6vlFqbNbO+7K+RvAE2+8XT8XRgbcv3es=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Baqb8LiXqaF1fGCO6Ldujft7yIivF7LQKFXTj6TqxVlKR9QLAF2FpnaS5XWkNJZlw+gdOmrrjEOfYFFoPoRKuqlBRmPVlNjXkCmoR6X7cZMgoXZ5Mwz+X82k0u3iNnhOerlzQSUDj5kDoEa1ObQecihIuEjB+B294GIZZHw6uVI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 24B29384DEE0 Received: by mail-qk1-x735.google.com with SMTP id af79cd13be357-7b6f8524f23so126746285a.2 for ; Thu, 16 Jan 2025 08:28:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zetier.com; s=gm; t=1737044920; x=1737649720; darn=sourceware.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jN2j5O7+5P0kIheEuEwk444+myPIMdEQzxoAkuyln+E=; b=RWtnFY1czc58M6PC03r08O/vljdKkAyOqF93jJjWWjknnKG6fJIbSo1BqHQV5X4AaD tR8/JAQNP6dt3kt19jv0h24wnJG9yPDUcN8AELKRxPOkkSFDNXpslDmmcdx3koHu7e5w I10dRr4rb0s6UoFlPpCpO//BqTtKNO3b3zJNXYgPJRx5QDaBm9CjiDzclJ6ZgbXdKY+H CTiRApEvAAiuo7BeOiTFi6zeRSdiOL6H/Cd+K+qv56Urh0ta75XJImpuMApSN8Kbls6/ 3RrwrBGVJ8CvgXrxywpui7X0FZkdRLlINuRFxC9eMqo5u7Ox3QVnnr89Ca/Mv8hfPC4i 6yXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737044920; x=1737649720; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=jN2j5O7+5P0kIheEuEwk444+myPIMdEQzxoAkuyln+E=; b=Du5bgUR53l5dXRdzVJRZjawWhdcWTwHQV+MqXsMrUZEkSHJDaaLp0iXpeBj/W+OBwr nXpVTSfm+238uLy59lMA0jQzuJuNDyiR8RpjQZk75PCasrF8eoV1BDEwlc2z2Y7MpCzz 8GNEmB1/eza7mCxsXqZB3AKe6aIFyIYVkW7pEECczwHpljToKHGZCRmvUdbdnN46jnzW 3ZAqb83ObXjmfhrcDim4rCWDc6K6FNHm2jPenARaCqZB8pU7rKU22PIFIweKNL6RfkAm CsyD/gqOcknRyufg566kpUoeu1jMVOqXgI0INEAZW40MF8jdKB68ORYK5oZOW2D+oW9r GNbw== X-Gm-Message-State: AOJu0Yz+n+GH/A347VDwlR/2CyqAIrCfYClWGP5MC/W6LFPCiFuw2czP f++8AHeKuVmaqrhMHXlHAmSMBPRbjH7KJZIoaJ8Mu8mc7C7j9gV1lsgq9zX+iMYSdKxvqJPHqG8 oFZI= X-Gm-Gg: ASbGncsnW2X0666jfOOy9K9DD4Ekh7oBR7/ern7xE3gHQFteYw3/P/sWca2g8wVZKoe 7eKCav18di4X4jjf5WJ0QfjqjZyFWDXpaN9JAMLDOlqxqu5hU4MlAY9hXnlJuDDB9zQEtpVlP6H 4UyUMrPoQ4quD4sod1OuRie+iMiar/GKHNPLdP2wvU4IBZQFQfl0Y7hubU8UXdmOl39EK2JeWx8 ZqeyvN0FVQ2qjfoGwR2Lt/8tZFsuex+QLDkrGl5d5KPjYnz63TPu/1NvfykdbOUMHnakNNh+w== X-Google-Smtp-Source: AGHT+IFD/hcLHNmPJPPqgXrnSnXZSeYGFha8Jlb2S2ef7rFClg6uZuQGvGGToRS3g8PVfWrLsn1rqw== X-Received: by 2002:a05:620a:3708:b0:7b6:913f:3df3 with SMTP id af79cd13be357-7bcd97aee44mr5508460985a.47.1737044920232; Thu, 16 Jan 2025 08:28:40 -0800 (PST) Received: from brandonb.zetier.com ([65.222.209.234]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7be614ef242sm18533285a.110.2025.01.16.08.28.39 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 16 Jan 2025 08:28:39 -0800 (PST) From: Brandon Belew To: Luis Machado Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] [PR corefiles/32441] Fix segfault if target_fileio_read_alloc fails In-Reply-To: <7c240023-20f7-41b4-8afc-f105c9785a35@arm.com> (Luis Machado's message of "Thu, 16 Jan 2025 10:27:08 +0000") References: <7c240023-20f7-41b4-8afc-f105c9785a35@arm.com> Date: Thu, 16 Jan 2025 11:28:25 -0500 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Thank you Luis for reviewing and responding to my comments in IRC! Just a f= ew more questions:=20 Luis Machado writes: > On 12/20/24 22:17, brandon.belew wrote: >> Check for target_fileio_read_alloc failure in linux_fill_prpsinfo >> before dereferencing buffer. This fixes a segfault in the 'gcore' >> command when attached to certain remote targets. >> --- >> This is my first contribution to GDB, and my first use of >> git-send-email, so please let me know if this is formatted >> incorrectly! I initially submitted the bug and a v1 patch at >> https://sourceware.org/bugzilla/show_bug.cgi?id=3D32441 and received the >> following from Thiago Bauermann: > > Formatting-wise, The commit message goes into the patch itself. See other= examples > on the list. It was my understanding of git-format-patch / git-send-email (and in reverse, git-am) that the commit message would be taken from everything up to the '---'. Then everything between the '---' and the actual diff was considered "timely commentary" and would not be present in the commit message. This typically contains the diffstat output but also is used for commentary on the patch that shouldn't go into the commit itself. As described in https://git-scm.com/docs/git-format-patch: > Typically it will be placed in a MUA=E2=80=99s drafts folder, edited to a= dd > timely commentary that should not go in the changelog ***after the > three dashes*** [emphasis added]=20 And also as described at https://spacekookie.de/blog/collaborating-with-git-send-email/: > Another often overlooked feature here is "timely commentary", are > comments in the patch e-mail that won't be part of the patch or the > commit message itself. They can be made after the --- marker in a > patch mail, but before the actual patch starts. This section is > usually used for the diff-stat of that particular patch. I tried sending the patch email to myself before I sent it to the list, piping it to `git-am`, and it correctly applied the commit without my "timely commentary", so I was pretty convinced I had formatted it correctly. Do you get something different when you `git am` my message? If so, can you be more specific about how I need to reformat the email? > Also, since you've opened a bug, we have hooks to refer to the bug. For i= nstance, > for commit ca263aec20adfffe6f9dab3a18f8a7b24667f99c. > > PR testsuite/32489 > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=3D32489 I'm confused about this - are you asking or suggesting that I format my message in a different way to take advantage of these hooks? Where are the hooks applied?=20 > The change itself looks OK to me. I'd like another pair of eyes to look at > it before we approve it. I think this can go in as a trivial change when = it > gets approved. > > Reviewed-By: Luis Machado Thank again for your review and help!=20 ~Brandon=20