Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andreas Jaeger <aj@suse.de>
To: Kevin Buettner <kevinb@redhat.com>
Cc: Michal Ludvig <mludvig@suse.cz>, gdb-patches@sources.redhat.com
Subject: Re: x86-64-tdep.h cleanup
Date: Tue, 05 Mar 2002 23:53:00 -0000	[thread overview]
Message-ID: <hovgcab08r.fsf@gee.suse.de> (raw)
In-Reply-To: <1020305162947.ZM18587@localhost.localdomain> (Kevin Buettner's message of "Tue, 5 Mar 2002 09:29:47 -0700")

Kevin Buettner <kevinb@redhat.com> writes:

> On Mar 5,  4:56pm, Michal Ludvig wrote:
>
>> As it was recommended by lots of people here I moved <sys/reg.h> along 
>> with regmap from x86-64-tdep.h to x86-64-linux-nat.c.
>> Also to let x86-64-tdep.h contain only #defines, I moved declarations of 
>> x86_64_linux_frame_saved_pc and x86_64_linux_saved_pc_after_call to 
>> x86-64-tdep.c. Are these changes OK to commit?
>> 
>> Michal Ludvig
>> 
>> Index: ChangeLog
>> from Michal Ludvig  <mludvig@suse.cz>
>> 
>> * x86-64-tdep.h (sys/reg.h, x86_64_regmap): Moved to x86-64-linux-nat.c
>> (x86_64_linux_frame_saved_pc,
>> x86_64_linux_saved_pc_after_call): Moved to x86-64-tdep.c
>> * x86-64-linux-nat.c (sys/reg.h, x86_64_regmap): Moved here
>> from x86-64-tdep.h
>> * x86-64-tdep.c (x86_64_linux_frame_saved_pc,
>> x86_64_linux_saved_pc_after_call): Moved here from x86-64-tdep.h
>
>
> Michael,
>
> I'm not the maintainer of the files in questions, but your changes
> look okay to me.

Since x86-64 is currently not officially (according to GDB
maintainership rules) by anybody, you have the right to ok this
change.  Is this an approval?

Thanks,
Andreas
-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.inka.de
    http://www.suse.de/~aj


  reply	other threads:[~2002-03-06  7:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-03-05  7:56 Michal Ludvig
2002-03-05  8:30 ` Kevin Buettner
2002-03-05 23:53   ` Andreas Jaeger [this message]
2002-03-06  2:00   ` Michal Ludvig
2002-03-06  9:30     ` Kevin Buettner
2002-03-07  5:30       ` [patch] " Michal Ludvig
2002-03-06  3:09 ` Andreas Schwab
2002-03-06  8:46   ` [RFA] " Michal Ludvig
2002-03-06  9:24     ` Andreas Schwab
2002-03-06  9:35       ` Kevin Buettner
2002-03-06 10:26         ` Andrew Cagney
2002-03-06 11:02           ` Kevin Buettner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=hovgcab08r.fsf@gee.suse.de \
    --to=aj@suse.de \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kevinb@redhat.com \
    --cc=mludvig@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox