From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-13215-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 32104 invoked by alias); 6 Mar 2002 07:53:42 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 32051 invoked from network); 6 Mar 2002 07:53:41 -0000
Received: from unknown (HELO Cantor.suse.de) (213.95.15.193)
  by sources.redhat.com with SMTP; 6 Mar 2002 07:53:41 -0000
Received: from Hermes.suse.de (Hermes.suse.de [213.95.15.136])
	by Cantor.suse.de (Postfix) with ESMTP
	id 384431E5EC; Wed,  6 Mar 2002 08:53:41 +0100 (MET)
X-Authentication-Warning: gee.suse.de: aj set sender to aj@suse.de using -f
To: Kevin Buettner <kevinb@redhat.com>
Cc: Michal Ludvig <mludvig@suse.cz>, gdb-patches@sources.redhat.com
Subject: Re: x86-64-tdep.h cleanup
References: <3C84EAA8.2000900@suse.cz>
	<1020305162947.ZM18587@localhost.localdomain>
From: Andreas Jaeger <aj@suse.de>
Date: Tue, 05 Mar 2002 23:53:00 -0000
In-Reply-To: <1020305162947.ZM18587@localhost.localdomain> (Kevin Buettner's
 message of "Tue, 5 Mar 2002 09:29:47 -0700")
Message-ID: <hovgcab08r.fsf@gee.suse.de>
User-Agent: Gnus/5.090006 (Oort Gnus v0.06) XEmacs/21.4 (Artificial
 Intelligence, i386-suse-linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2002-03/txt/msg00067.txt.bz2

Kevin Buettner <kevinb@redhat.com> writes:

> On Mar 5,  4:56pm, Michal Ludvig wrote:
>
>> As it was recommended by lots of people here I moved <sys/reg.h> along 
>> with regmap from x86-64-tdep.h to x86-64-linux-nat.c.
>> Also to let x86-64-tdep.h contain only #defines, I moved declarations of 
>> x86_64_linux_frame_saved_pc and x86_64_linux_saved_pc_after_call to 
>> x86-64-tdep.c. Are these changes OK to commit?
>> 
>> Michal Ludvig
>> 
>> Index: ChangeLog
>> from Michal Ludvig  <mludvig@suse.cz>
>> 
>> * x86-64-tdep.h (sys/reg.h, x86_64_regmap): Moved to x86-64-linux-nat.c
>> (x86_64_linux_frame_saved_pc,
>> x86_64_linux_saved_pc_after_call): Moved to x86-64-tdep.c
>> * x86-64-linux-nat.c (sys/reg.h, x86_64_regmap): Moved here
>> from x86-64-tdep.h
>> * x86-64-tdep.c (x86_64_linux_frame_saved_pc,
>> x86_64_linux_saved_pc_after_call): Moved here from x86-64-tdep.h
>
>
> Michael,
>
> I'm not the maintainer of the files in questions, but your changes
> look okay to me.

Since x86-64 is currently not officially (according to GDB
maintainership rules) by anybody, you have the right to ok this
change.  Is this an approval?

Thanks,
Andreas
-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.inka.de
    http://www.suse.de/~aj