Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michal Ludvig <mludvig@suse.cz>
To: gdb-patches@sources.redhat.com
Cc: Kevin Buettner <kevinb@redhat.com>
Subject: Re: x86-64-tdep.h cleanup
Date: Wed, 06 Mar 2002 02:00:00 -0000	[thread overview]
Message-ID: <3C85E8B8.5030102@suse.cz> (raw)
In-Reply-To: <1020305162947.ZM18587@localhost.localdomain>

Kevin Buettner wrote:
> On Mar 5,  4:56pm, Michal Ludvig wrote:
>>* x86-64-tdep.h (sys/reg.h, x86_64_regmap): Moved to x86-64-linux-nat.c
>>(x86_64_linux_frame_saved_pc,
>>x86_64_linux_saved_pc_after_call): Moved to x86-64-tdep.c
>>* x86-64-linux-nat.c (sys/reg.h, x86_64_regmap): Moved here
>>from x86-64-tdep.h
>>* x86-64-tdep.c (x86_64_linux_frame_saved_pc,
>>x86_64_linux_saved_pc_after_call): Moved here from x86-64-tdep.h


> I'm not the maintainer of the files in questions, but your changes
> look okay to me.

There is no maintainer of this port right now. Can I understand your 
message as an approval?

> should be written like this instead:
> 
> 	* x86-64-tdep.c (x86_64_linux_frame_saved_pc)
> 	(x86_64_linux_saved_pc_after_call): Moved here from x86-64-tdep.h.
> 
> (I've been told that emacs is happier if ChangeLog entries are
> formatted this way.)

Thanks for notice, I reformatted them.
Michal Ludvig
-- 
* SuSE CR, s.r.o     * mludvig@suse.cz
* +420 2 9654 5373   * http://www.suse.cz


  parent reply	other threads:[~2002-03-06 10:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-03-05  7:56 Michal Ludvig
2002-03-05  8:30 ` Kevin Buettner
2002-03-05 23:53   ` Andreas Jaeger
2002-03-06  2:00   ` Michal Ludvig [this message]
2002-03-06  9:30     ` Kevin Buettner
2002-03-07  5:30       ` [patch] " Michal Ludvig
2002-03-06  3:09 ` Andreas Schwab
2002-03-06  8:46   ` [RFA] " Michal Ludvig
2002-03-06  9:24     ` Andreas Schwab
2002-03-06  9:35       ` Kevin Buettner
2002-03-06 10:26         ` Andrew Cagney
2002-03-06 11:02           ` Kevin Buettner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C85E8B8.5030102@suse.cz \
    --to=mludvig@suse.cz \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kevinb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox