From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17371 invoked by alias); 6 Mar 2002 10:00:31 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17283 invoked from network); 6 Mar 2002 10:00:26 -0000 Received: from unknown (HELO kerberos.suse.cz) (195.47.106.10) by sources.redhat.com with SMTP; 6 Mar 2002 10:00:26 -0000 Received: from chimera.suse.cz (chimera.suse.cz [10.20.0.2]) by kerberos.suse.cz (SuSE SMTP server) with ESMTP id 4000959D363; Wed, 6 Mar 2002 11:00:25 +0100 (CET) Received: from suse.cz (leviathan.suse.cz [10.20.1.56]) by chimera.suse.cz (8.11.0/8.11.0/SuSE Linux 8.11.0-0.4) with ESMTP id g26A0ON18710; Wed, 6 Mar 2002 11:00:24 +0100 X-Authentication-Warning: chimera.suse.cz: Host leviathan.suse.cz [10.20.1.56] claimed to be suse.cz Message-ID: <3C85E8B8.5030102@suse.cz> Date: Wed, 06 Mar 2002 02:00:00 -0000 From: Michal Ludvig Organization: SuSE CR User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.8) Gecko/20020204 X-Accept-Language: cs, cz, en MIME-Version: 1.0 To: gdb-patches@sources.redhat.com Cc: Kevin Buettner Subject: Re: x86-64-tdep.h cleanup References: <3C84EAA8.2000900@suse.cz> <1020305162947.ZM18587@localhost.localdomain> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-03/txt/msg00068.txt.bz2 Kevin Buettner wrote: > On Mar 5, 4:56pm, Michal Ludvig wrote: >>* x86-64-tdep.h (sys/reg.h, x86_64_regmap): Moved to x86-64-linux-nat.c >>(x86_64_linux_frame_saved_pc, >>x86_64_linux_saved_pc_after_call): Moved to x86-64-tdep.c >>* x86-64-linux-nat.c (sys/reg.h, x86_64_regmap): Moved here >>from x86-64-tdep.h >>* x86-64-tdep.c (x86_64_linux_frame_saved_pc, >>x86_64_linux_saved_pc_after_call): Moved here from x86-64-tdep.h > I'm not the maintainer of the files in questions, but your changes > look okay to me. There is no maintainer of this port right now. Can I understand your message as an approval? > should be written like this instead: > > * x86-64-tdep.c (x86_64_linux_frame_saved_pc) > (x86_64_linux_saved_pc_after_call): Moved here from x86-64-tdep.h. > > (I've been told that emacs is happier if ChangeLog entries are > formatted this way.) Thanks for notice, I reformatted them. Michal Ludvig -- * SuSE CR, s.r.o * mludvig@suse.cz * +420 2 9654 5373 * http://www.suse.cz