Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Vladimir Prus <vladimir@codesourcery.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Report the main thread.
Date: Sun, 11 May 2008 14:45:00 -0000	[thread overview]
Message-ID: <g06se1$vf9$1@ger.gmane.org> (raw)
In-Reply-To: <18470.7609.400548.29643@kahikatea.snap.net.nz>

Nick Roberts wrote:

>  > > Now that Joel has requested that I use observer_attach_new_thread for
>  > > annotations this approach doesn't only produce MI output so it needs to
>  > > be conditioned on MI:
>  > > 
>  > > @@ -124,6 +124,10 @@ add_thread_silent (ptid_t ptid)
>  > >    tp->num = ++highest_thread_num;
>  > >    tp->next = thread_list;
>  > >    thread_list = tp;
>  > > +
>  > > +  if (ui_out_is_mi_like_p (uiout))
>  > > +    observer_notify_new_thread (tp);
>  > 
>  > This patch, IIUC, will cause the new_thread observer to be notified only
>  > in MI mode. Then, no observer except for MI one will ever be called?
>  > Then, why those non-MI observers exist?
>  > 
>  > Or to put in other way, I think this patch will make you annotation
>  > observers to be never called. Is this what you want?
> 
> Yes, you're right.  I didn't notice that the observer in add_thread_with_info
> was removed at the same time this one was added.
> 
> I just want threads other than the main thread to be reported, as used to
> be the case.  

Assuming that makes sense for annotations, I think your observer is in position
to decide which threads to report, and which not?

> That way I can create a threads buffer and display the thread 
> number when there is more than one thread.  

Cannot you just suppress display of thread list if there's just one
thread reported, on UI side?

- Volodya



  reply	other threads:[~2008-05-11 13:31 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-10 18:00 Nick Roberts
2008-05-10 19:26 ` Vladimir Prus
2008-05-11 14:10   ` Nick Roberts
2008-05-11 14:45     ` Vladimir Prus [this message]
2008-05-11 15:52       ` Nick Roberts
2008-05-11 16:00         ` Vladimir Prus
2008-05-11 16:13           ` Nick Roberts
2008-05-11 16:41             ` Vladimir Prus
2008-05-11 22:19               ` Nick Roberts
2008-05-12 22:22         ` Michael Snyder
2008-05-11 20:19       ` Joel Brobecker
2008-05-11 21:10         ` Vladimir Prus
2008-05-11 22:33         ` Nick Roberts
2008-05-12  3:18           ` Daniel Jacobowitz
2008-05-12 16:11             ` Nick Roberts
2008-05-12 18:19               ` Daniel Jacobowitz
2008-05-10 19:42 ` Vladimir Prus
2008-05-10 22:12 ` Joel Brobecker
2008-05-11 14:29   ` Nick Roberts
  -- strict thread matches above, loose matches on Subject: below --
2008-04-26 16:44 Vladimir Prus
2008-04-26 17:16 ` Mark Kettenis
2008-04-26 17:22   ` Daniel Jacobowitz
2008-04-26 17:31   ` Vladimir Prus
2008-04-26 21:05     ` Daniel Jacobowitz
2008-04-26 22:36       ` Vladimir Prus
2008-04-27  4:27         ` Nick Roberts
2008-04-27  9:03           ` Vladimir Prus
2008-04-27 11:14           ` Daniel Jacobowitz
2008-04-27 14:24             ` Nick Roberts
2008-04-27 13:53               ` Nick Roberts
2008-04-27 15:50               ` Daniel Jacobowitz
2008-04-27 16:07                 ` Mark Kettenis
2008-04-27 16:07                   ` Pedro Alves
2008-04-27 21:46                     ` Mark Kettenis
2008-04-28  3:31                       ` Pedro Alves
2008-04-27 18:25                   ` Daniel Jacobowitz
2008-04-30 10:11         ` Vladimir Prus
2008-04-30 13:28           ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='g06se1$vf9$1@ger.gmane.org' \
    --to=vladimir@codesourcery.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox