Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Vladimir Prus <vladimir@codesourcery.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Report the main thread.
Date: Wed, 30 Apr 2008 10:11:00 -0000	[thread overview]
Message-ID: <fv98il$qts$1@ger.gmane.org> (raw)
In-Reply-To: <fuvu3o$j27$2@ger.gmane.org>

Vladimir Prus wrote:

> Daniel Jacobowitz wrote:
> 
>> On Sat, Apr 26, 2008 at 08:44:23PM +0400, Vladimir Prus wrote:
>>> Will some approach that only produce MI output be fine with you?
>> 
>> Perhaps that means any observer for a new MI thread should go in
>> add_thread_silent?
> 
> Yes, moving the observer call to add_thread_silent is the most
> direct approach to make MI work the way I want without disturbing CLI.

Here's a patch to that effect. OK?

        * thread.c (add_thread): Move observer call to ...
        (add_thread_silent): ... here.
---
 gdb/thread.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/gdb/thread.c b/gdb/thread.c
index 46e6ba7..d3cfb32 100644
--- a/gdb/thread.c
+++ b/gdb/thread.c
@@ -124,6 +124,9 @@ add_thread_silent (ptid_t ptid)
   tp->num = ++highest_thread_num;
   tp->next = thread_list;
   thread_list = tp;
+
+  observer_notify_new_thread (tp);
+
   return tp;
 }
 
@@ -136,8 +139,6 @@ add_thread_with_info (ptid_t ptid, struct private_thread_info *private)
 
   if (print_thread_events)
     printf_unfiltered (_("[New %s]\n"), target_pid_to_str (ptid));
-
-  observer_notify_new_thread (result);
   
   return result;
 }



  parent reply	other threads:[~2008-04-30  7:54 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-26 16:44 Vladimir Prus
2008-04-26 17:16 ` Mark Kettenis
2008-04-26 17:22   ` Daniel Jacobowitz
2008-04-26 17:31   ` Vladimir Prus
2008-04-26 21:05     ` Daniel Jacobowitz
2008-04-26 22:36       ` Vladimir Prus
2008-04-27  4:27         ` Nick Roberts
2008-04-27  9:03           ` Vladimir Prus
2008-04-27 11:14           ` Daniel Jacobowitz
2008-04-27 14:24             ` Nick Roberts
2008-04-27 13:53               ` Nick Roberts
2008-04-27 15:50               ` Daniel Jacobowitz
2008-04-27 16:07                 ` Mark Kettenis
2008-04-27 16:07                   ` Pedro Alves
2008-04-27 21:46                     ` Mark Kettenis
2008-04-28  3:31                       ` Pedro Alves
2008-04-27 18:25                   ` Daniel Jacobowitz
2008-04-30 10:11         ` Vladimir Prus [this message]
2008-04-30 13:28           ` Daniel Jacobowitz
2008-05-10 18:00 Nick Roberts
2008-05-10 19:26 ` Vladimir Prus
2008-05-11 14:10   ` Nick Roberts
2008-05-11 14:45     ` Vladimir Prus
2008-05-11 15:52       ` Nick Roberts
2008-05-11 16:00         ` Vladimir Prus
2008-05-11 16:13           ` Nick Roberts
2008-05-11 16:41             ` Vladimir Prus
2008-05-11 22:19               ` Nick Roberts
2008-05-12 22:22         ` Michael Snyder
2008-05-11 20:19       ` Joel Brobecker
2008-05-11 21:10         ` Vladimir Prus
2008-05-11 22:33         ` Nick Roberts
2008-05-12  3:18           ` Daniel Jacobowitz
2008-05-12 16:11             ` Nick Roberts
2008-05-12 18:19               ` Daniel Jacobowitz
2008-05-10 19:42 ` Vladimir Prus
2008-05-10 22:12 ` Joel Brobecker
2008-05-11 14:29   ` Nick Roberts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='fv98il$qts$1@ger.gmane.org' \
    --to=vladimir@codesourcery.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox