Re: [RFA] Report the main thread.

[Vladimir Prus <vladimir@codesourcery.com>]

On Sunday 11 May 2008 18:09:30 Nick Roberts wrote:
>  > > Yes, you're right.  I didn't notice that the observer in
>  > > add_thread_with_info was removed at the same time this one was added.
>  > > 
>  > > I just want threads other than the main thread to be reported, as used to
>  > > be the case.  
>  > 
>  > Assuming that makes sense for annotations, I think your observer is in
>  > position to decide which threads to report, and which not?
> 
> Currently the new_thread observer only declares struct thread_info

What do you mean? The observer does not declare struct thread_info, it declares
a parameter having type 'struct thread_info'. 

> and not it's 
> members so I can't identify the thread number in annotate.c

struct thread_info is defined in gdbthread.h. What prevents you from including
that header?

>  > > That way I can create a threads buffer and display the thread 
>  > > number when there is more than one thread.  
>  > 
>  > Cannot you just suppress display of thread list if there's just one
>  > thread reported, on UI side?
> 
> Yes, I could count the new-thread annotations and and only trigger things when
> there is more than one thread.  It's simpler if I don't have to and I'm just
> baffled why I need to go through these hoops for a small stop gap change that
> no-one else is interested in using.  The only requirement I can see on such a
> patch is that it doesn't affect anybody else's use of Gdb, and I think my
> original patch filled that requirement.

I have no opinion on this point (and I was not involved in the discussion of 
your original patch).

- Volodya