Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Vrany via Gdb-patches <gdb-patches@sourceware.org>
To: Simon Marchi <simon.marchi@polymtl.ca>,
	Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: change "maint info jit" to print jit_code_entry::symfile_addr value
Date: Tue, 08 Feb 2022 19:32:37 +0000	[thread overview]
Message-ID: <ffab42d1cf6fc302d4d0adf0c9d9d753e10c6886.camel@labware.com> (raw)
In-Reply-To: <08201dca-f8e2-3c2e-b5d3-9bb45e105d75@polymtl.ca>

On Tue, 2022-02-08 at 14:16 -0500, Simon Marchi wrote:
> 
> On 2022-02-08 10:49, Andrew Burgess via Gdb-patches wrote:
> > Jan,
> > 
> > Thanks for this patch.  While reviewing this, I wondered about using
> > ui_out's table mechanism to format the output, rather than just
> > printing the addresses.
> > 
> > Additionally, while reminding myself about how the jit stuff works, I
> > thought, maybe we should keep the jit_code_entry address in the 'maint
> > info jit' output - after all, given a jit_code_entry, we can, in
> > theory, figure out the symfile address, but we can't (easily) go from
> > a symfile address back to a jit_code_entry, right?
> 
> Why not print both?

I believe this is what Andrew's patch does. 

> > Anyway, while I ended up with the patch below.  What do you think
> > about this instead?

Andrew, I'm happy with it, of course. 

Jan

> 
> Simon



  reply	other threads:[~2022-02-08 19:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-07 11:39 Jan Vrany via Gdb-patches
2022-02-08 15:49 ` Andrew Burgess via Gdb-patches
2022-02-08 19:16   ` Simon Marchi via Gdb-patches
2022-02-08 19:32     ` Jan Vrany via Gdb-patches [this message]
2022-02-08 20:15       ` Simon Marchi via Gdb-patches
2022-02-11 14:53         ` Andrew Burgess via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ffab42d1cf6fc302d4d0adf0c9d9d753e10c6886.camel@labware.com \
    --to=gdb-patches@sourceware.org \
    --cc=aburgess@redhat.com \
    --cc=jan.vrany@labware.com \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox