From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qLc9K3PFAmJPZgAAWB0awg (envelope-from ) for ; Tue, 08 Feb 2022 14:33:07 -0500 Received: by simark.ca (Postfix, from userid 112) id AEE1E1F3C6; Tue, 8 Feb 2022 14:33:07 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5CC541EE1F for ; Tue, 8 Feb 2022 14:33:07 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D949C3857C44 for ; Tue, 8 Feb 2022 19:33:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D949C3857C44 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1644348786; bh=QozNCGTlWyCktBRrOXod7x5od+xWO6+Ibzru/ptK5sI=; h=Subject:To:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=tv/1ZwHLheZ0KmQE17e2ezTsDsNNf2p5MphH1R5988b70O6MQ41b5FZaB5nCQGPvq NrjZGh18hRAFlBtif0DvQ/43ZP49O8/5p3xCk2x2hH2NJi+uVXX0Z7VsKJqgjR5tZx f4yMP/NSPCNl0VOkSfe0oF4DUOVcrNcciekzdRs4= Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam08on2080.outbound.protection.outlook.com [40.107.102.80]) by sourceware.org (Postfix) with ESMTPS id 0211C3858D1E for ; Tue, 8 Feb 2022 19:32:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0211C3858D1E ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SCiRGPxq30ExLyF4aJiNTm+nBqR44674tld6tNIEqrTrQhBTA8vQkTQagZh7FtfwznRXcW3nqgA3R65LKE9FEdTk56eyF0ZhEpfBR98iOIShlfFJskEmtG0B8n6VZPTYBKb9/7HyeWiq+19hqzWwf4HZhxXjJGBTfmOas17AqSIWz7iKjKXPyMZ3wfC3rtr+J4b7mTIKykc/RQxi/vqYzTZrK+o0dcjMBfImiuaa7F6wvdnx45PBAToyhxwPiQG0rbgoNlenj+IiF3+j8H/OxQMX31XJ0SxnqxqEla8fB/OFtqwC0cIzd/1ZvlzFoREvfxYMvrdckSrYXG65H28zZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QozNCGTlWyCktBRrOXod7x5od+xWO6+Ibzru/ptK5sI=; b=CbyZUOHMM0iPBGF2WSGsTyyFRFv8kZnnKh9aTjQWcRtibFeYfti5M4y/yZmiJtowIzaxoI1A3dox23whzB34l5Avy3OuGJDGv718yLqAs0AnBRicdCLGjBYT+DTnNUfVEf/e+5fL6Jwt04uMLEQIto7pq4kduliijQW6PjE2BoMtuwOSCs4hbErVKeb3WlqKRLxcxeM2CyxzTeCElpilvYo0qXmGI6AIbFwAsEhCzCAnVBdQ8E7TWE/gro/TJOy7XjtuZvSFVbpfvjsgk3drLFgOSuYCWywyy5Ja+QJywHjwy1d8dPsQhKXWm3578eoXxumtsuKIUUTVZYmR8ChrCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from BN6PR17MB3106.namprd17.prod.outlook.com (2603:10b6:405:7d::31) by DM6PR17MB3483.namprd17.prod.outlook.com (2603:10b6:5:203::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Tue, 8 Feb 2022 19:32:42 +0000 Received: from BN6PR17MB3106.namprd17.prod.outlook.com ([fe80::4cea:a210:b6d:c047]) by BN6PR17MB3106.namprd17.prod.outlook.com ([fe80::4cea:a210:b6d:c047%4]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022 19:32:42 +0000 Message-ID: Subject: Re: [PATCH] gdb: change "maint info jit" to print jit_code_entry::symfile_addr value To: Simon Marchi , Andrew Burgess Date: Tue, 08 Feb 2022 19:32:37 +0000 In-Reply-To: <08201dca-f8e2-3c2e-b5d3-9bb45e105d75@polymtl.ca> References: <20220207113923.2366281-1-jan.vrany@labware.com> <20220208154937.GF2706@redhat.com> <08201dca-f8e2-3c2e-b5d3-9bb45e105d75@polymtl.ca> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0114.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:192::11) To BN6PR17MB3106.namprd17.prod.outlook.com (2603:10b6:405:7d::31) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: de26dab7-f6a3-435f-b7b4-08d9eb39c60f X-MS-TrafficTypeDiagnostic: DM6PR17MB3483:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ct/QxEQxDG8bD0r0T3y7vvigbuOqe/v0Z/MhiAflPoi2uCNC8QNuljiB8zi8K6TQebpqtU60217oSsr8DT8fQM6LQRFtSWhJwYIJfllAH4xTdKZJGsksaKHFUQiMeN2woGhwiXC0dtZAOeMfw32cBhUGXdgpj9CZxxLYGfopX7XKlOHe5DaOhW5sJ6bfMGYTP4ar4HkZOmPsDBS9tLmbBr7GKwGZXYhHbUkZyEYvqmOntWgEU8yUgUnleGrXa9aRXWnAgvblLN1w02j4bQqEgMKSJIlMgzWczSHvFAoyYU5W/SODEWr47Yi6D3hgPWCAh3Z910OMhUvToBQp+ezg1/KfgZ/vGcRoNz4UMcnU4jNKBJUNBMlaqVl1a9bAUS5u/l4MZoVrBljxndHZWP167fn3FeqVBVCz3aR21K53QK44zMsC3hJRn5WvS0QLBDkhiFNBZdI+C7ff8+ZG1EuFQlyEUhbNcmlcpQCu5M8hHni8FYoTIU3H5emhrEwzUTLZJWJSe/pvlqwbY2ptfEQuUU9WDa4skVW3ysxh7GU7eMMMhG2OXmZ5xXCP5af6VfDEsmx3KHzhQLBK2PuktepNXolksofx7v5evpzzNFfG16LYQCbUiM4JR5pVVEUHgFzPozDHllMRP5E7QPlUZgKrGA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR17MB3106.namprd17.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(2616005)(4326008)(66556008)(44832011)(8936002)(66476007)(4744005)(36756003)(8676002)(508600001)(6486002)(66946007)(110136005)(86362001)(53546011)(186003)(6512007)(38100700002)(5660300002)(52116002)(6506007)(6666004)(2906002)(316002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TG8rZFp1YU52enFISTIyVDZndVVRVTNCMlRFS2wzMFZkamljRW9BdkN3VmtO?= =?utf-8?B?WXZMbGhyRlpiVi9KQit2MTQ5WWl2NXpMc0JrU0lPUHJVVG1FTTcxV1pCUGZv?= =?utf-8?B?UnNZZ25nRmNYZVRwbStjSjc2cU1pYjY3eU9ZU3l4YTRSY0V3SWQrN2NFYkxI?= =?utf-8?B?c3VGU0daWTA0czkrVmk3REJZaGw3L2labitTdHJad205RnNUR0NCYmsxcnhu?= =?utf-8?B?T0w2N3ZxTDBIVzczTEdsUGJ3ZVc4MTZGRXlqMXVDOUtnY1FQZm9OR0cvcTVH?= =?utf-8?B?dXJsR242OHY5d0F3SGd5bEZMZHptWFgwMHYvM1JtOWhJWm0rZ0REVTd4Zld3?= =?utf-8?B?aVJKWld5MzY5Y0VwYWNlWDlFbDQ0TEhCR1ZNMG1DalVTSG9KNzFUajcrSVEx?= =?utf-8?B?ODZmTWtHUkZoemhMWlpaUXpheXpmSk5MbG96MHg5ZXNMRTZ5Y3FHT0JNMnBP?= =?utf-8?B?bWVYNUJYd0RYNmRSTlB0alZtV0ZpRGVPajFmMHlwMVA2TkE2c0RCRUg5amV2?= =?utf-8?B?bktjeUozQ1lyRWk0eGIxcEJScU1yRGpmejQrNUxIbkt1ZUN4aFJvSnltUlZz?= =?utf-8?B?MEhab3NOTTNnWnVQUDZ1N0o3elN4aUlFTXlESUI0MW5KQTJkRFBXc2JPNktF?= =?utf-8?B?Z3MyMkMxTG9IQVNmZjhpd0hwVnk1dXY5dXhIOXdYK2dZbENJMXI0T1hqNzhi?= =?utf-8?B?V0o0cVkyWDQvc3FvQkxZQ1puRTdPbGkyYjdJZXAvWWFBSldtS1pvbm9wR0g1?= =?utf-8?B?VXVoQTNHbE41NnpaTjRtTWhFdXVyMzZTR3JVT211cUFJdmRsZlV2UjNpcnZu?= =?utf-8?B?WktjZ0NKMkFOTmxGMlc3WkE4RHlUNXlaSEFueHBOVklyVWFHdFF2UjE5OEx2?= =?utf-8?B?NGVOK1l2QXVvTm9EUXdySlV3Y0dHUzBFOEU4ZmUydW1WdVRLL2ZvelMzZzU3?= =?utf-8?B?b0RrS3d1b1JmcEdYZVNVTWlxRFIxMnhkVHNTMkxyYmRqR2JoNW83SFB2Nk5p?= =?utf-8?B?Z2p2MktBYUFTTWNrUGxMbXdkWVRIaGNwM002ZUhxMnA0T1NhRkVKbWZMVTBu?= =?utf-8?B?S0lVRlR6ZDhsZDRXVE5PQ1hBUHJmZmNsRHdWL0U2aTFvYjFydFgrOUt6NHIx?= =?utf-8?B?U3lMS3FGalhoVmpHYjVCVFNNcmhqT2l1SW02TUtaODJYK1NTdHlpZEtEWlRJ?= =?utf-8?B?dlVTTjN4a1Q2aTBycXl5ejVpSWZud3JFS2hRZ3FMb0xVZHA2RlNxbGcxUjBz?= =?utf-8?B?Z0xualR3SC9RK09SblZqTW5iMCtPdjlRSWdLalM4VnByRGIwZmtDMmRyeGxG?= =?utf-8?B?OUI4L0x1Y1ZxTXc5RUZsaHh4ZER1cWFFM1NZa0pUZ0RFZ2pUeFhtWEF5dHpN?= =?utf-8?B?dnAwZDYxMi9IbWt3WDVzclJWdlVZSjZzZTMrcDJtVlpjbE9WYVZac1VuWTBW?= =?utf-8?B?SDVJMm1YUlNKSUltUVdOWnNvdUNKSkNqclpGZTRyQTUzeVpwTEJ3L2o4SXQx?= =?utf-8?B?RGZjalpmUUpKU1luOVNVMnY1dW9iZzVjTVN2OWg4UVFLSmJxSHhyKzlGWW1Y?= =?utf-8?B?LzhmcHJYditQdWxEWEZVSVA3emVWbnNkNkpQVjZFN0ozOU5RSi91Zlc2N3R2?= =?utf-8?B?SHlrd08zNzVqQ2lCeEFxV2czOUJZcFI4MHpWVmhqcG9YNUpmVGlnaEN0ekZR?= =?utf-8?B?WDV6dDQxbnQ5UWZrMk1EQ2hkQkd3dzBFaTgvRVR4UUJlYjUrSGtmS0krMS9V?= =?utf-8?B?RVpGMWlCQzV3QS94ZnV6Rk1IcHZPczEzNDYzMUR2VHJpelg4UTd2NUFCR3gx?= =?utf-8?B?RXpqcEl6Uld4VXpudVpwTkhsTG80TlVEQlZOQmJZQWpuMkhBd1RmWm1MZWpz?= =?utf-8?B?a3N5UGtyOEFqcWpkY0VzYk01ZDhjYVFvd2V5WUxLOVRZOG1veE0xQ2hWSE51?= =?utf-8?B?cDh3OHlaZmxaL0ZqUFFhNGdoeXdOK1VpcFd4WkxHQ29EenBNS1BXcXJiWjRl?= =?utf-8?B?MTR6SFNuRkNORUg0bEFLMUlWYUgzY3JQdjRmTlpYaityMjhyWWQxU2FBNFJv?= =?utf-8?B?NkJ5WGNtajZXbDkrREs1dGkwT205MG44dktaZW5zWnRXV1kwUy8vMFVWWTYz?= =?utf-8?B?UkRsejlLNTBCVzMvY0xlNEFhdnhxZGJkU09DYVVTS3JDWm9aZWt3Tm9GV3FN?= =?utf-8?B?SldvVytBNFQ5bStSSXBBQkdOdkF1Ni9yNEhiM1dTSlExVTVqaXYrUE5ieG5F?= =?utf-8?Q?worJkRg49icC9V2Bee6hb31S1jZlkiotGot67WGvac=3D?= X-OriginatorOrg: labware.com X-MS-Exchange-CrossTenant-Network-Message-Id: de26dab7-f6a3-435f-b7b4-08d9eb39c60f X-MS-Exchange-CrossTenant-AuthSource: BN6PR17MB3106.namprd17.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 19:32:42.1655 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b5db0322-1aa0-4c0a-859c-ad0f96966f4c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lMKCA37Cive5cYa0bjXyFZy3xEhT7KIgOaQ5gNtpOA3edxXUZAxF9PCU6vOpRCxq4XPYGBZ0w6PMnkc3yrm86w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR17MB3483 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Jan Vrany via Gdb-patches Reply-To: Jan Vrany Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Tue, 2022-02-08 at 14:16 -0500, Simon Marchi wrote: > > On 2022-02-08 10:49, Andrew Burgess via Gdb-patches wrote: > > Jan, > > > > Thanks for this patch. While reviewing this, I wondered about using > > ui_out's table mechanism to format the output, rather than just > > printing the addresses. > > > > Additionally, while reminding myself about how the jit stuff works, I > > thought, maybe we should keep the jit_code_entry address in the 'maint > > info jit' output - after all, given a jit_code_entry, we can, in > > theory, figure out the symfile address, but we can't (easily) go from > > a symfile address back to a jit_code_entry, right? > > Why not print both? I believe this is what Andrew's patch does. > > Anyway, while I ended up with the patch below. What do you think > > about this instead? Andrew, I'm happy with it, of course. Jan > > Simon