From: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Jan Vrany <jan.vrany@labware.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: change "maint info jit" to print jit_code_entry::symfile_addr value
Date: Fri, 11 Feb 2022 14:53:52 +0000 [thread overview]
Message-ID: <20220211145352.GB2571@redhat.com> (raw)
In-Reply-To: <3ba3c0f8-5afe-ba0b-ba39-ee8aa1a5b8c9@polymtl.ca>
* Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> [2022-02-08 15:15:21 -0500]:
>
>
> On 2022-02-08 14:32, Jan Vrany wrote:
> > On Tue, 2022-02-08 at 14:16 -0500, Simon Marchi wrote:
> >>
> >> On 2022-02-08 10:49, Andrew Burgess via Gdb-patches wrote:
> >>> Jan,
> >>>
> >>> Thanks for this patch. While reviewing this, I wondered about using
> >>> ui_out's table mechanism to format the output, rather than just
> >>> printing the addresses.
> >>>
> >>> Additionally, while reminding myself about how the jit stuff works, I
> >>> thought, maybe we should keep the jit_code_entry address in the 'maint
> >>> info jit' output - after all, given a jit_code_entry, we can, in
> >>> theory, figure out the symfile address, but we can't (easily) go from
> >>> a symfile address back to a jit_code_entry, right?
> >>
> >> Why not print both?
> >
> > I believe this is what Andrew's patch does.
> >
> >>> Anyway, while I ended up with the patch below. What do you think
> >>> about this instead?
> >
> > Andrew, I'm happy with it, of course.
>
> Ah, I'm happy with it too then :).
Thanks both. I pushed this patch.
Andrew
prev parent reply other threads:[~2022-02-11 14:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 11:39 Jan Vrany via Gdb-patches
2022-02-08 15:49 ` Andrew Burgess via Gdb-patches
2022-02-08 19:16 ` Simon Marchi via Gdb-patches
2022-02-08 19:32 ` Jan Vrany via Gdb-patches
2022-02-08 20:15 ` Simon Marchi via Gdb-patches
2022-02-11 14:53 ` Andrew Burgess via Gdb-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220211145352.GB2571@redhat.com \
--to=gdb-patches@sourceware.org \
--cc=aburgess@redhat.com \
--cc=jan.vrany@labware.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox