From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4GhVDJl4BmLrXAAAWB0awg (envelope-from ) for ; Fri, 11 Feb 2022 09:54:17 -0500 Received: by simark.ca (Postfix, from userid 112) id 3047C1F3C8; Fri, 11 Feb 2022 09:54:17 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D42171EDF0 for ; Fri, 11 Feb 2022 09:54:16 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1A675385843B for ; Fri, 11 Feb 2022 14:54:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1A675385843B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1644591256; bh=Brw/gp/cIPKFV/eP+kjTN37yTgCsczGYDtdNxmG5uDA=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Ho3jJiAX9nwSAVHKFYxXv0BqVGjgQP9xwyY1bBBT6W45b0Dj2qknMkzENG1Miehm7 5H3xhfiBr8ReUq/MdobKwNHFOlZ3dF0U1SaAJqbWkfWFYUC4OOiD+iobaDRh/pIv/3 M3Y2czhfxbUdiJWeIZj4CxNWpcJt9pLXMNcE9bYU= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id B63C83858D1E for ; Fri, 11 Feb 2022 14:53:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B63C83858D1E Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-287-YJr_5mspMqGLqgku13TI-w-1; Fri, 11 Feb 2022 09:53:55 -0500 X-MC-Unique: YJr_5mspMqGLqgku13TI-w-1 Received: by mail-wm1-f72.google.com with SMTP id v190-20020a1cacc7000000b0034657bb6a66so881507wme.6 for ; Fri, 11 Feb 2022 06:53:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Brw/gp/cIPKFV/eP+kjTN37yTgCsczGYDtdNxmG5uDA=; b=y5L4ipqqnkIAwtcgZXEAJsn3PJIzl9xVz1NkzRHBQ1n8RNUQ3v22nBxN1tCpu97p/d cyGemgNOx98ZgkKxI4rJeq5nUghVnSRLCTRbIfbtyWrYWZ2kAeyF6EkRUDl7nSXuWFWN SoUPX2lpuU9d1MQ2JH4XOIBLteo5VR5WCv6ZUrhRZSdrnsd1aqR96C3XvQsYdyBARmLY KBxZLlGxlDlPjRr63mtES743Eoyl+F20TR5i886mS0yGj9R7JXasCimtZC/u3fVXHzWc x5cqhDfd8UQCP/AMOAJsY08jsqeE/hGWyp4lTDfEO2hluMTKxerbQ/m6jfBJ0b32XTR2 /SLA== X-Gm-Message-State: AOAM532LrBQLbv3tQMlSo3oKVJuQUpOnVr8Z0u3JMIf+MQrBhN6qQMq4 cIssrsEnsvHqhYjM3X1fkHLBuf6K2i6tkbA6Rmdn6GSGEO6qUI0pwm4sp013i2XK9tT/KSOrFSq IfuC8Ks3JwggexD7XUlIlYA== X-Received: by 2002:adf:e5ca:: with SMTP id a10mr1634864wrn.151.1644591233738; Fri, 11 Feb 2022 06:53:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJwjrxRzOy0eCM5GLQT0XM8aJ+FsqrjZ8irdff/x5ezemW+JWxMlj9wLJGxDqmQ9eosqoiLUIw== X-Received: by 2002:adf:e5ca:: with SMTP id a10mr1634855wrn.151.1644591233559; Fri, 11 Feb 2022 06:53:53 -0800 (PST) Received: from localhost (host86-134-151-224.range86-134.btcentralplus.com. [86.134.151.224]) by smtp.gmail.com with ESMTPSA id e15sm7530269wrg.6.2022.02.11.06.53.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Feb 2022 06:53:53 -0800 (PST) Date: Fri, 11 Feb 2022 14:53:52 +0000 To: Simon Marchi Subject: Re: [PATCH] gdb: change "maint info jit" to print jit_code_entry::symfile_addr value Message-ID: <20220211145352.GB2571@redhat.com> References: <20220207113923.2366281-1-jan.vrany@labware.com> <20220208154937.GF2706@redhat.com> <08201dca-f8e2-3c2e-b5d3-9bb45e105d75@polymtl.ca> <3ba3c0f8-5afe-ba0b-ba39-ee8aa1a5b8c9@polymtl.ca> MIME-Version: 1.0 In-Reply-To: <3ba3c0f8-5afe-ba0b-ba39-ee8aa1a5b8c9@polymtl.ca> X-Operating-System: Linux/5.8.18-100.fc31.x86_64 (x86_64) X-Uptime: 14:53:33 up 4:32, 1 X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Andrew Burgess via Gdb-patches Reply-To: Andrew Burgess Cc: Jan Vrany , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" * Simon Marchi via Gdb-patches [2022-02-08 15:15:21 -0500]: > > > On 2022-02-08 14:32, Jan Vrany wrote: > > On Tue, 2022-02-08 at 14:16 -0500, Simon Marchi wrote: > >> > >> On 2022-02-08 10:49, Andrew Burgess via Gdb-patches wrote: > >>> Jan, > >>> > >>> Thanks for this patch. While reviewing this, I wondered about using > >>> ui_out's table mechanism to format the output, rather than just > >>> printing the addresses. > >>> > >>> Additionally, while reminding myself about how the jit stuff works, I > >>> thought, maybe we should keep the jit_code_entry address in the 'maint > >>> info jit' output - after all, given a jit_code_entry, we can, in > >>> theory, figure out the symfile address, but we can't (easily) go from > >>> a symfile address back to a jit_code_entry, right? > >> > >> Why not print both? > > > > I believe this is what Andrew's patch does. > > > >>> Anyway, while I ended up with the patch below. What do you think > >>> about this instead? > > > > Andrew, I'm happy with it, of course. > > Ah, I'm happy with it too then :). Thanks both. I pushed this patch. Andrew