Re: [PATCH v2] gdb: make find_memory_region_ftype a function_view

[Simon Marchi <simon.marchi@polymtl.ca>]

On 2026-03-19 09:57, Tom Tromey wrote:
>>>>>> "Simon" == simon marchi <simon.marchi@polymtl.ca> writes:
> 
> Simon> From: Simon Marchi <simon.marchi@polymtl.ca>
> Simon> New in v2:
> 
> Simon>  - new header file find-memory-region.h
> 
> Simon> Make it a function_view and remove the `void *` parameter.  Convert the
> Simon> callers (in gcore.c) to use lambda functions that capture `obfd`.
> 
> Simon> The target_debug_print_find_memory_region_ftype debug printer isn't
> Simon> terribly useful, but I don't see a good way to print a function_view
> Simon> with what we have right now.
> 
> Simon> Since find_memory_region_ftype needs to be seen by both gdbarch.h and
> Simon> target.h, I chose to move the typedef to a new file
> Simon> (find-memory-region.h), that is included by both.
> 
> Looks good to me.
> Approved-By: Tom Tromey <tom@tromey.com>
> 
> Tom

Thanks, pushed.

Simon