From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id zYrQN7UDvGkRSjAAWB0awg (envelope-from ) for ; Thu, 19 Mar 2026 10:09:57 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=xTA2uTTa; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D588D1E0C3; Thu, 19 Mar 2026 10:09:57 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E83061E08C for ; Thu, 19 Mar 2026 10:09:56 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 51A3A4C31827 for ; Thu, 19 Mar 2026 14:09:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 51A3A4C31827 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=xTA2uTTa Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 005974BB3BFC for ; Thu, 19 Mar 2026 14:08:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 005974BB3BFC Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 005974BB3BFC Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773929332; cv=none; b=kHkPOc8tcvHiVxlHTRr1J0eF4hWv9ypXaXLg41qtF8Q8lHUck38I2LxQrStNglhrsWIS3eEsskBgaDlSULcxtP5I+h4LhVvPRNW41UpIQaJ9t/qnEnKR0Ba0og+SClNDG6gECn9uaKYgqawGT0vnaj7s4bi5RimQBTFW/jqdSQs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773929332; c=relaxed/simple; bh=h9vj+W6vUwsqYjSEeuRraFx6z6AVeDJAIHO/ScbGci0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Y302alyifqC6/clcXRoXdtMH4B3ATgKeA+D7ghusa33xX+cyLT868eTDBSnypN0TzhAsguQ8camG+w5h8QfjDKRgj61pyXnKPHOIHhbTta/IkuwE1eoPLtAFyc6zqN8B3dmbLgPYu9PJhHokY7CA9FRpdmy5o8HRAeAofeDM2T8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 005974BB3BFC Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 62JE8kcp139535 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Mar 2026 10:08:51 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 62JE8kcp139535 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1773929331; bh=AAYbrhD7M53K604gUn7QVumbZ1BtSYq3fX57aJRqPNw=; h=Date:Subject:To:Cc:From:In-Reply-To:From; b=xTA2uTTa/5rERakpPx8noRp62Fa7z7HMLHv66ECUDlEFXnI/NOY/F6ZzE2aaV4K/D 8mjZ5wTyUwdyWwinmcW0Y2h0YZilwOA/Vunr+th0y9LIMbQtXGA8LQ0O7Y1yO0NvCz aiWOzBqed92qWiMOxtNSVG+POwZzQzLNaKft0gof8TcVljwoHxaFZeqkjmLPCZ2pEm NpaGtI84D4rrsKMLDdzpcK2PFsbFzxd6xglUquufIo4pPMFkXvM1+1jbwH2hf3RstD Iq4UGAriwjo6yxIaJne/7NrT+WZR6WCTjfCTWbOqmDkLEI2WteP/3eLRAFizWlUbsl R+t28uRJrYgHA== Received: by simark.ca (Postfix) id 92EC11E08C; Thu, 19 Mar 2026 10:08:44 -0400 (EDT) Message-ID: Date: Thu, 19 Mar 2026 10:08:43 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] gdb: make find_memory_region_ftype a function_view To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260310173104.676640-5-simon.marchi@polymtl.ca> <20260314190611.2813869-1-simon.marchi@polymtl.ca> <87341vc46g.fsf@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <87341vc46g.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 19 Mar 2026 14:08:46 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-03-19 09:57, Tom Tromey wrote: >>>>>> "Simon" == simon marchi writes: > > Simon> From: Simon Marchi > Simon> New in v2: > > Simon> - new header file find-memory-region.h > > Simon> Make it a function_view and remove the `void *` parameter. Convert the > Simon> callers (in gcore.c) to use lambda functions that capture `obfd`. > > Simon> The target_debug_print_find_memory_region_ftype debug printer isn't > Simon> terribly useful, but I don't see a good way to print a function_view > Simon> with what we have right now. > > Simon> Since find_memory_region_ftype needs to be seen by both gdbarch.h and > Simon> target.h, I chose to move the typedef to a new file > Simon> (find-memory-region.h), that is included by both. > > Looks good to me. > Approved-By: Tom Tromey > > Tom Thanks, pushed. Simon