From: Tom Tromey <tom@tromey.com>
To: simon.marchi@polymtl.ca
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] gdb: make find_memory_region_ftype a function_view
Date: Thu, 19 Mar 2026 07:57:43 -0600 [thread overview]
Message-ID: <87341vc46g.fsf@tromey.com> (raw)
In-Reply-To: <20260314190611.2813869-1-simon.marchi@polymtl.ca> (simon marchi's message of "Sat, 14 Mar 2026 15:06:01 -0400")
>>>>> "Simon" == simon marchi <simon.marchi@polymtl.ca> writes:
Simon> From: Simon Marchi <simon.marchi@polymtl.ca>
Simon> New in v2:
Simon> - new header file find-memory-region.h
Simon> Make it a function_view and remove the `void *` parameter. Convert the
Simon> callers (in gcore.c) to use lambda functions that capture `obfd`.
Simon> The target_debug_print_find_memory_region_ftype debug printer isn't
Simon> terribly useful, but I don't see a good way to print a function_view
Simon> with what we have right now.
Simon> Since find_memory_region_ftype needs to be seen by both gdbarch.h and
Simon> target.h, I chose to move the typedef to a new file
Simon> (find-memory-region.h), that is included by both.
Looks good to me.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2026-03-19 13:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 17:30 [PATCH 1/5] gdb/linux-tdep: check return value of linux_find_memory_region_ftype callback simon.marchi
2026-03-10 17:30 ` [PATCH 2/5] gdb/gcore: check return values of some find_memory_region_ftype calls simon.marchi
2026-03-13 18:21 ` Tom Tromey
2026-03-10 17:30 ` [PATCH 3/5] gdb/linux-tdep: make linux_find_memory_region_ftype a function_view simon.marchi
2026-03-13 18:25 ` Tom Tromey
2026-03-10 17:30 ` [PATCH 4/5] gdb/linux-tdep: remove linux_collect_thread_registers_ftype typedef simon.marchi
2026-03-13 18:25 ` Tom Tromey
2026-03-14 18:43 ` Simon Marchi
2026-03-10 17:30 ` [PATCH 5/5] gdb: make find_memory_region_ftype a function_view simon.marchi
2026-03-13 18:46 ` Tom Tromey
2026-03-14 18:48 ` Simon Marchi
2026-03-14 19:06 ` [PATCH v2] " simon.marchi
2026-03-19 13:57 ` Tom Tromey [this message]
2026-03-19 14:08 ` Simon Marchi
2026-03-13 18:21 ` [PATCH 1/5] gdb/linux-tdep: check return value of linux_find_memory_region_ftype callback Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87341vc46g.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox