From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id rZTPAvoAvGnSRjAAWB0awg (envelope-from ) for ; Thu, 19 Mar 2026 09:58:18 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=VbScGEuU; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id EF4D01E08C; Thu, 19 Mar 2026 09:58:17 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 154C91E08C for ; Thu, 19 Mar 2026 09:58:17 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id AC3634BC8986 for ; Thu, 19 Mar 2026 13:58:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AC3634BC8986 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=VbScGEuU Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id 959D14BC8948 for ; Thu, 19 Mar 2026 13:57:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 959D14BC8948 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 959D14BC8948 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773928667; cv=none; b=lgrNr6/OcWFP2T8iDSLhBtKZrPEMFoq75zA8jx5a6yuejsXO/2AJks9Q1BPtr8+EB483biZMIZiDKuElIMvWtshbAS3Ef8nX6gwNFh+vKuUhEemwWN8vhVTP/KMjkLOyrmauOOBpgLOSfdqjqrrMFchga3X6m+CCU6x6KtR4Mws= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773928667; c=relaxed/simple; bh=YAHlSfm6m6RgdR5/rExTkvlLr4kU2lLEgLFkb3uc7v8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=DuvTS0e+fCJHBLXXQkdMzbANuL0ZnRuFBm6Q12KkrG4omPMn6j4Bj6o2sIK0ZbABftmF4MuKuBwcKPxotvMSekFQKJw714V19wHil7VNvnv9ZE7/RUDwkl9bM8LRNPTZ/4SWbR9Wviws7apLX2aFEPLw7J23+KFWQFfmWgIf+4M= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 959D14BC8948 Received: from eig-obgw-6002b.ext.cloudfilter.net ([10.0.30.203]) by cmsmtp with ESMTPS id 3Cvaw3vRGCxrG3DshwoKOw; Thu, 19 Mar 2026 13:57:47 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 3DsgwlhGTPL323Dsgw8VWm; Thu, 19 Mar 2026 13:57:46 +0000 X-Authority-Analysis: v=2.4 cv=MqhS63ae c=1 sm=1 tr=0 ts=69bc00da a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=Yq5XynenixoA:10 a=ItBw4LHWJt0A:10 a=_ZhYKdCeAAAA:8 a=zstS-IiYAAAA:8 a=pid09x3BkkNc8kxKxn0A:9 a=uqOk3ZSnBfCTOznnrPA1:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=aP1oMZJX0qxNeAPSPw/EDvFmgRqzTJXiUDW8h+OdOaY=; b=VbScGEuUrB7AwIz+GpvhdKhRsq UnyQB/9nPyJ0bbZj4UnC+hauf1I2YCktu5wyvSXucty4t/9/G3ochmpMxAXMuN9dOON/FcZ9cVzgS /8PjxzfdRn9KIHF29EMXzmqZn; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:37172 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1w3Dsf-00000001mqY-0Zzq; Thu, 19 Mar 2026 07:57:45 -0600 From: Tom Tromey To: simon.marchi@polymtl.ca Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] gdb: make find_memory_region_ftype a function_view In-Reply-To: <20260314190611.2813869-1-simon.marchi@polymtl.ca> (simon marchi's message of "Sat, 14 Mar 2026 15:06:01 -0400") References: <20260310173104.676640-5-simon.marchi@polymtl.ca> <20260314190611.2813869-1-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Thu, 19 Mar 2026 07:57:43 -0600 Message-ID: <87341vc46g.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1w3Dsf-00000001mqY-0Zzq X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:37172 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfJfbUAyMex8F989BNuWGz67oBDFAywQM24P964SPHa/Qbv9+dulp0Qrh8G9xhLLmXERqfH7hrux/cJxft9pjbW0nLBPqNikQyxDIz6XLBErSED8UJFrv L7Lu01ufephCjdMi2jDlmV7puwHEAzGuMaUvgoqBZK60NUhZMi7S55cSwOaV2wTKWBlH5DkFqJWv7L7vx1UMeQ4bpa4GaBJ6LuM= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == simon marchi writes: Simon> From: Simon Marchi Simon> New in v2: Simon> - new header file find-memory-region.h Simon> Make it a function_view and remove the `void *` parameter. Convert the Simon> callers (in gcore.c) to use lambda functions that capture `obfd`. Simon> The target_debug_print_find_memory_region_ftype debug printer isn't Simon> terribly useful, but I don't see a good way to print a function_view Simon> with what we have right now. Simon> Since find_memory_region_ftype needs to be seen by both gdbarch.h and Simon> target.h, I chose to move the typedef to a new file Simon> (find-memory-region.h), that is included by both. Looks good to me. Approved-By: Tom Tromey Tom