Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@palves.net>
To: Lancelot SIX <lsix@lancelotsix.com>
Cc: gdb-patches@sourceware.org
Subject: [pushed] Don't include sys/personality.h in linux-low.cc anymore
Date: Sat, 8 May 2021 13:11:23 +0100	[thread overview]
Message-ID: <fda07a04-8db9-82bc-2c96-2c44e0873dd4@palves.net> (raw)
In-Reply-To: <20210507174251.o4nd4trlmrin2exm@Plymouth>

On 2021-05-07 6:42 p.m., Lancelot SIX wrote:
> Hi,
> 
> From what I can see, this include is not needed in this file anymore and
> could be removed altogether.  It seems to have been forgotten in a past
> refactoring[1].
> 
> Lancelot.
> 
> [1] https://sourceware.org/pipermail/gdb-patches/2015-January/120503.html
> 

Indeed.  I've pushed this patch below.  Thanks!

From e2ea3a381a4a7c739419a8b76a2fd132f7c1f9b1 Mon Sep 17 00:00:00 2001
From: Pedro Alves <pedro@palves.net>
Date: Sat, 8 May 2021 12:54:43 +0100
Subject: [PATCH] Don't include sys/personality.h in linux-low.cc anymore

Lancelot pointed out that since the refactor at:

  https://sourceware.org/pipermail/gdb-patches/2015-January/120503.html

the sys/personality.h include is not needed in linux-low.cc anymore,
as it does not call personality directly itself anymore.

gdbserver/ChangeLog:

	* linux-low.cc: Don't include sys/personality.h or define
	ADDR_NO_RANDOMIZE.
---
 gdbserver/ChangeLog    | 5 +++++
 gdbserver/linux-low.cc | 7 -------
 2 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/gdbserver/ChangeLog b/gdbserver/ChangeLog
index 94e489939c1..1047697b0ed 100644
--- a/gdbserver/ChangeLog
+++ b/gdbserver/ChangeLog
@@ -1,3 +1,8 @@
+2021-05-08  Pedro Alves  <pedro@palves.net>
+
+	* linux-low.cc: Don't include sys/personality.h or define
+	ADDR_NO_RANDOMIZE.
+
 2021-05-06  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 
 	* server.cc (handle_v_attach)
diff --git a/gdbserver/linux-low.cc b/gdbserver/linux-low.cc
index 251a54f5c4a..ca3d25943df 100644
--- a/gdbserver/linux-low.cc
+++ b/gdbserver/linux-low.cc
@@ -60,13 +60,6 @@
 #endif
 #include "nat/linux-namespaces.h"
 
-#ifdef HAVE_PERSONALITY
-# include <sys/personality.h>
-# if !HAVE_DECL_ADDR_NO_RANDOMIZE
-#  define ADDR_NO_RANDOMIZE 0x0040000
-# endif
-#endif
-
 #ifndef O_LARGEFILE
 #define O_LARGEFILE 0
 #endif

base-commit: 8a16cc4b934b2dee897837b7c68b9393cfd5ef5a
-- 
2.26.2


  reply	other threads:[~2021-05-08 12:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-06 22:43 [PATCH] Don't run personality syscall at configure time; don't check it at all Pedro Alves
2021-05-07 14:13 ` Tom Tromey
2021-05-07 17:42 ` Lancelot SIX via Gdb-patches
2021-05-08 12:11   ` Pedro Alves [this message]
2021-05-12 18:24 ` Tom Tromey
2021-05-12 19:56   ` Pedro Alves
2021-05-12 19:58     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fda07a04-8db9-82bc-2c96-2c44e0873dd4@palves.net \
    --to=pedro@palves.net \
    --cc=gdb-patches@sourceware.org \
    --cc=lsix@lancelotsix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox