From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id XQ0REfZ/lmD+XwAAWB0awg (envelope-from ) for ; Sat, 08 May 2021 08:11:34 -0400 Received: by simark.ca (Postfix, from userid 112) id 379421F11C; Sat, 8 May 2021 08:11:34 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3EB171E813 for ; Sat, 8 May 2021 08:11:31 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AC805385481A; Sat, 8 May 2021 12:11:30 +0000 (GMT) Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by sourceware.org (Postfix) with ESMTPS id DE3B1385800F for ; Sat, 8 May 2021 12:11:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DE3B1385800F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=alves.ped@gmail.com Received: by mail-wr1-f41.google.com with SMTP id v12so11832935wrq.6 for ; Sat, 08 May 2021 05:11:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=F4YMPEeOXT3B1BCofaL2iK8m2jygHXZyN4wRZ32NN5k=; b=dYgks2eMXy6S9o5FHT5bD/W6eZS6X3EDbhI+yfhkTvAP/P+bvYYh3AmPm+C91r9fEZ 5GtjT5sc+vGLx9gQtMn66GnORM5l1fxM4Yxh9KrtCxSWQShR2gjaZfMcZt2wDm9Gok08 FmH1RC5bHLkKDjZMtk1UCrG3KoJs5+qfJaliR0+zUJNNaIM/sIbnu4tF1Ggdwf5g1wU8 MtayaNmY68b/tCGdNSskwVYTj2WnWJyGkZsJNQ17q4ngXldJk7YWOfC2DwwWB+uBJOix Mq2ZF9hoReC5lm816xzdsJKEJCV/tvgPt5DRb9ZvwI4nNMxhIt/QW1aYvVkkSvvOzk5T JDQA== X-Gm-Message-State: AOAM530dUpcVJYFLFAr7H6EWUqcIxpjrIb1nJO8CIPmPkiU0vOZxnYOi GppzEedNVnBoJDVgoVhQ833CVhpKc11zp92a X-Google-Smtp-Source: ABdhPJw5QzFFSazA0/O/iXiVgkLPS7mEZQ98ji9/nHz570zXBepgRHZfpaJPv1a8z3/ldwjirAS8jA== X-Received: by 2002:adf:f948:: with SMTP id q8mr18950765wrr.296.1620475886307; Sat, 08 May 2021 05:11:26 -0700 (PDT) Received: from [192.168.88.233] ([83.240.185.138]) by smtp.gmail.com with ESMTPSA id o82sm10547975wmo.36.2021.05.08.05.11.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 08 May 2021 05:11:25 -0700 (PDT) Subject: [pushed] Don't include sys/personality.h in linux-low.cc anymore From: Pedro Alves To: Lancelot SIX References: <20210506224341.398202-1-pedro@palves.net> <20210507174251.o4nd4trlmrin2exm@Plymouth> Message-ID: Date: Sat, 8 May 2021 13:11:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210507174251.o4nd4trlmrin2exm@Plymouth> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-05-07 6:42 p.m., Lancelot SIX wrote: > Hi, > > From what I can see, this include is not needed in this file anymore and > could be removed altogether. It seems to have been forgotten in a past > refactoring[1]. > > Lancelot. > > [1] https://sourceware.org/pipermail/gdb-patches/2015-January/120503.html > Indeed. I've pushed this patch below. Thanks! >From e2ea3a381a4a7c739419a8b76a2fd132f7c1f9b1 Mon Sep 17 00:00:00 2001 From: Pedro Alves Date: Sat, 8 May 2021 12:54:43 +0100 Subject: [PATCH] Don't include sys/personality.h in linux-low.cc anymore Lancelot pointed out that since the refactor at: https://sourceware.org/pipermail/gdb-patches/2015-January/120503.html the sys/personality.h include is not needed in linux-low.cc anymore, as it does not call personality directly itself anymore. gdbserver/ChangeLog: * linux-low.cc: Don't include sys/personality.h or define ADDR_NO_RANDOMIZE. --- gdbserver/ChangeLog | 5 +++++ gdbserver/linux-low.cc | 7 ------- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/gdbserver/ChangeLog b/gdbserver/ChangeLog index 94e489939c1..1047697b0ed 100644 --- a/gdbserver/ChangeLog +++ b/gdbserver/ChangeLog @@ -1,3 +1,8 @@ +2021-05-08 Pedro Alves + + * linux-low.cc: Don't include sys/personality.h or define + ADDR_NO_RANDOMIZE. + 2021-05-06 Tankut Baris Aktemur * server.cc (handle_v_attach) diff --git a/gdbserver/linux-low.cc b/gdbserver/linux-low.cc index 251a54f5c4a..ca3d25943df 100644 --- a/gdbserver/linux-low.cc +++ b/gdbserver/linux-low.cc @@ -60,13 +60,6 @@ #endif #include "nat/linux-namespaces.h" -#ifdef HAVE_PERSONALITY -# include -# if !HAVE_DECL_ADDR_NO_RANDOMIZE -# define ADDR_NO_RANDOMIZE 0x0040000 -# endif -#endif - #ifndef O_LARGEFILE #define O_LARGEFILE 0 #endif base-commit: 8a16cc4b934b2dee897837b7c68b9393cfd5ef5a -- 2.26.2