From: Tom Tromey <tromey@adacore.com>
To: Pedro Alves <pedro@palves.net>
Cc: gdb-patches@sourceware.org, Tom Tromey <tromey@adacore.com>
Subject: Re: [PATCH] Don't run personality syscall at configure time; don't check it at all
Date: Wed, 12 May 2021 13:58:56 -0600 [thread overview]
Message-ID: <87mtsz67wf.fsf@tromey.com> (raw)
In-Reply-To: <317fecaf-8a74-605f-410b-7625ca1429b4@palves.net> (Pedro Alves's message of "Wed, 12 May 2021 20:56:30 +0100")
Pedro> - AC_CHECK_DECLS([ADDR_NO_RANDOMIZE],,, [#include <sys/personality.h>])
>> ... and the corresponding define in nat/linux-personality.c.
>>
>> (I tried just including the linux/ header but it doesn't declare
>> 'personality'.)
Pedro> Would it work to just include both?
No, they both define the same enum constants, so I think this wouldn't
work.
Pedro> Otherwise, do we really need the configure check? Wouldn't just:
Pedro> #ifndef ADDR_NO_RANDOMIZE
Pedro> # define ADDR_NO_RANDOMIZE 0x0040000
Pedro> #endif
Pedro> work the same?
They neglected to use the self-#define trick for these constants.
Tom
prev parent reply other threads:[~2021-05-12 19:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-06 22:43 Pedro Alves
2021-05-07 14:13 ` Tom Tromey
2021-05-07 17:42 ` Lancelot SIX via Gdb-patches
2021-05-08 12:11 ` [pushed] Don't include sys/personality.h in linux-low.cc anymore Pedro Alves
2021-05-12 18:24 ` [PATCH] Don't run personality syscall at configure time; don't check it at all Tom Tromey
2021-05-12 19:56 ` Pedro Alves
2021-05-12 19:58 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtsz67wf.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox