From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id TCUfKIQznGAeZQAAWB0awg (envelope-from ) for ; Wed, 12 May 2021 15:59:00 -0400 Received: by simark.ca (Postfix, from userid 112) id 9C36B1F11C; Wed, 12 May 2021 15:59:00 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8D4C41E01F for ; Wed, 12 May 2021 15:58:59 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5115F3853821; Wed, 12 May 2021 19:58:59 +0000 (GMT) Received: from rock.gnat.com (rock.gnat.com [IPv6:2620:20:4000:0:a9e:1ff:fe9b:1d1]) by sourceware.org (Postfix) with ESMTP id A93B93857C75 for ; Wed, 12 May 2021 19:58:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A93B93857C75 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 7FC65561A3; Wed, 12 May 2021 15:58:57 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id AwfvO8sDP9Wm; Wed, 12 May 2021 15:58:57 -0400 (EDT) Received: from murgatroyd (75-166-134-27.hlrn.qwest.net [75.166.134.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPSA id 2281F561A0; Wed, 12 May 2021 15:58:57 -0400 (EDT) From: Tom Tromey To: Pedro Alves Subject: Re: [PATCH] Don't run personality syscall at configure time; don't check it at all References: <20210506224341.398202-1-pedro@palves.net> <87r1ib6c9s.fsf@tromey.com> <317fecaf-8a74-605f-410b-7625ca1429b4@palves.net> X-Attribution: Tom Date: Wed, 12 May 2021 13:58:56 -0600 In-Reply-To: <317fecaf-8a74-605f-410b-7625ca1429b4@palves.net> (Pedro Alves's message of "Wed, 12 May 2021 20:56:30 +0100") Message-ID: <87mtsz67wf.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org, Tom Tromey Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Pedro> - AC_CHECK_DECLS([ADDR_NO_RANDOMIZE],,, [#include ]) >> ... and the corresponding define in nat/linux-personality.c. >> >> (I tried just including the linux/ header but it doesn't declare >> 'personality'.) Pedro> Would it work to just include both? No, they both define the same enum constants, so I think this wouldn't work. Pedro> Otherwise, do we really need the configure check? Wouldn't just: Pedro> #ifndef ADDR_NO_RANDOMIZE Pedro> # define ADDR_NO_RANDOMIZE 0x0040000 Pedro> #endif Pedro> work the same? They neglected to use the self-#define trick for these constants. Tom