From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 21/22] Use SCOPE_EXIT in write_gcore_file
Date: Wed, 06 Mar 2019 22:54:00 -0000 [thread overview]
Message-ID: <fcf2c99d-f602-cff3-b58a-1a6187f7f260@redhat.com> (raw)
In-Reply-To: <87bm2nljnr.fsf@tromey.com>
--
Thanks,
Pedro Alves
On 03/06/2019 10:31 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Pedro> You could rebase this on current master and push it in, to get it
> Pedro> out of the way.
>
> Unless there's a need, I'd rather leave it as-is, since rebasing it
> earlier means tweaking other patches earlier in the series.
The only tweak othe other patches would need would be to not touch
the file at all. This patch eliminates the need for any of the
previous changes to the same code.
>
> Pedro> You could also merge patches #1-#13, the cleanup-elimination patches
> Pedro> until the TRY/CATCH parts. I'll need a bit more time to comment
> Pedro> on those TRY/CATCH parts, so I've skipped them tonight.
>
> I don't mind waiting, it's not a super rush to get this in.
> Thanks for looking through these.
I'd think getting the cleanups elimination patches in would be
good for the fact that it makes it impossible for anyone else to
end up adding new cleanups meanwhile. And, it makes the remainder
patches a smaller self-contained series; any new repost would be
much smaller.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2019-03-06 22:54 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 20:18 [PATCH v2 00/22] Remove cleanups Tom Tromey
2019-02-27 20:18 ` [PATCH v2 08/22] Remove last cleanup solib-aix.c Tom Tromey
2019-03-06 19:34 ` Pedro Alves
2019-03-06 21:19 ` Tom Tromey
2019-02-27 20:18 ` [PATCH v2 05/22] Remove last cleanup from gdbserver Tom Tromey
2019-03-06 19:23 ` Pedro Alves
2019-02-27 20:19 ` [PATCH v2 02/22] Update two cleanup comments Tom Tromey
2019-03-06 19:23 ` Pedro Alves
2019-02-27 20:19 ` [PATCH v2 17/22] Rename gdb exception types Tom Tromey
2019-02-27 20:19 ` [PATCH v2 18/22] Remove some now-dead exception code Tom Tromey
2019-04-03 17:04 ` Pedro Alves
2019-02-27 20:19 ` [PATCH v2 01/22] Remove cleanups from coffread.c Tom Tromey
2019-03-06 19:23 ` Pedro Alves
2019-02-27 20:19 ` [PATCH v2 11/22] Use unique_xmalloc_ptr in remote.c Tom Tromey
2019-03-06 21:17 ` Pedro Alves
2019-02-27 20:19 ` [PATCH v2 10/22] Remove last cleanups from stabsread.c Tom Tromey
2019-03-06 21:14 ` Pedro Alves
2019-02-27 20:19 ` [PATCH v2 15/22] Make exceptions use std::string and be self-managing Tom Tromey
2019-04-03 16:20 ` Pedro Alves
2019-04-03 17:58 ` Tom Tromey
2019-04-03 18:28 ` Pedro Alves
2019-02-27 20:19 ` [PATCH v2 16/22] Rewrite TRY/CATCH Tom Tromey
2019-04-03 17:03 ` Pedro Alves
2019-04-03 18:02 ` Tom Tromey
2019-02-27 20:19 ` [PATCH v2 12/22] Remove basic cleanup code Tom Tromey
2019-03-06 21:33 ` Pedro Alves
2019-02-27 20:19 ` [PATCH v2 22/22] Introduce and use bcache_up Tom Tromey
2019-03-06 22:03 ` Pedro Alves
2019-03-07 16:54 ` Tom Tromey
2019-03-07 17:09 ` Pedro Alves
2019-03-07 17:42 ` Tom Tromey
2019-02-27 20:19 ` [PATCH v2 13/22] Remove free_current_contents Tom Tromey
2019-03-06 21:34 ` Pedro Alves
2019-02-27 20:19 ` [PATCH v2 03/22] Change displaced_step_clear_cleanup with a forward_scope_exit Tom Tromey
2019-03-06 19:23 ` Pedro Alves
2019-02-27 20:19 ` [PATCH v2 19/22] Make exception throwing a bit more efficient Tom Tromey
2019-04-03 17:04 ` Pedro Alves
2019-02-27 20:19 ` [PATCH v2 09/22] Remove last cleanup from linux-namespaces.c Tom Tromey
2019-03-06 21:07 ` Pedro Alves
2019-02-27 20:19 ` [PATCH v2 06/22] Remove cleanup from solib-svr4.c Tom Tromey
2019-03-06 19:24 ` Pedro Alves
2019-02-27 20:19 ` [PATCH v2 04/22] C++ify remote notification code Tom Tromey
2019-03-06 19:23 ` Pedro Alves
2019-03-06 21:12 ` Tom Tromey
2019-02-27 20:19 ` [PATCH v2 14/22] Simplify exception handling Tom Tromey
2019-04-02 22:07 ` Pedro Alves
2019-02-27 20:19 ` [PATCH v2 07/22] Remove last cleanups from solib-svr4.c Tom Tromey
2019-03-06 19:32 ` Pedro Alves
2019-03-06 19:39 ` John Baldwin
2019-03-06 21:18 ` Tom Tromey
2019-02-27 20:19 ` [PATCH v2 20/22] Replace throw_exception with throw in some cases Tom Tromey
2019-04-03 17:05 ` Pedro Alves
2019-02-27 20:19 ` [PATCH v2 21/22] Use SCOPE_EXIT in write_gcore_file Tom Tromey
2019-03-06 22:01 ` Pedro Alves
2019-03-06 22:31 ` Tom Tromey
2019-03-06 22:54 ` Pedro Alves [this message]
2019-03-06 22:56 ` Tom Tromey
2019-03-06 23:08 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcf2c99d-f602-cff3-b58a-1a6187f7f260@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox