From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2 04/22] C++ify remote notification code
Date: Wed, 06 Mar 2019 19:23:00 -0000 [thread overview]
Message-ID: <6f911dfb-3018-33b0-fbb1-48ece1607c1e@redhat.com> (raw)
In-Reply-To: <20190227201849.32210-5-tom@tromey.com>
On 02/27/2019 08:18 PM, Tom Tromey wrote:
> This C++ifies the remote notification code -- replacing function
> pointers with virtual methods and using unique_ptr. This allows for
> the removal of some cleanups.
>
> gdb/ChangeLog
> 2019-02-27 Tom Tromey <tom@tromey.com>
>
> * remote.c (struct stop_reply_deleter): Remove.
> (stop_reply_up): Update.
> (struct stop_reply): Derive from notif_event. Don't typedef.
> <regcache>: Now a std::vector.
> (stop_reply_xfree): Remove.
> (stop_reply::~stop_reply): Rename from stop_reply_dtr.
> (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
> (remote_target::discard_pending_stop_replies): Use delete.
> (remote_target::remote_parse_stop_reply): Update.
> (remote_target::process_stop_reply): Update.
> * remote-notif.h (struct notif_event): Add virtual destructor.
> Remove "dtr" member.
> (struct notif_client) <alloc_event>: Return a unique_ptr.
> (notif_event_xfree): Don't declare.
> * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
> (notif_event_xfree, do_notif_event_xfree): Remove.
> (remote_notif_state_xfree): Update.
> ---
> gdb/ChangeLog | 20 ++++++++++++
> gdb/remote-notif.c | 42 ++++--------------------
> gdb/remote-notif.h | 11 +++----
> gdb/remote.c | 80 +++++++++++++---------------------------------
> 4 files changed, 54 insertions(+), 99 deletions(-)
>
> diff --git a/gdb/remote-notif.c b/gdb/remote-notif.c
> index ae9a94d9c94..5a70ca128d5 100644
> --- a/gdb/remote-notif.c
> +++ b/gdb/remote-notif.c
> @@ -52,8 +52,6 @@ static struct notif_client *notifs[] =
>
> gdb_static_assert (ARRAY_SIZE (notifs) == REMOTE_NOTIF_LAST);
>
> -static void do_notif_event_xfree (void *arg);
> -
> /* Parse the BUF for the expected notification NC, and send packet to
> acknowledge. */
>
> @@ -61,18 +59,14 @@ void
> remote_notif_ack (remote_target *remote,
> struct notif_client *nc, const char *buf)
> {
> - struct notif_event *event = nc->alloc_event ();
> - struct cleanup *old_chain
> - = make_cleanup (do_notif_event_xfree, event);
> + std::unique_ptr<struct notif_event> event = nc->alloc_event ();
"std::unique_ptr<struct notif_event>" appears in a number of places
in the patch. Did you consider adding a "notif_event_up" typedef ?
> -typedef std::unique_ptr<stop_reply, stop_reply_deleter> stop_reply_up;
> +typedef std::unique_ptr<struct stop_reply> stop_reply_up;
Odd that you added the "struct". I tend to remove it when touching
code instead. :-)
Anyway, patch is OK.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2019-03-06 19:23 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 20:18 [PATCH v2 00/22] Remove cleanups Tom Tromey
2019-02-27 20:18 ` [PATCH v2 08/22] Remove last cleanup solib-aix.c Tom Tromey
2019-03-06 19:34 ` Pedro Alves
2019-03-06 21:19 ` Tom Tromey
2019-02-27 20:18 ` [PATCH v2 05/22] Remove last cleanup from gdbserver Tom Tromey
2019-03-06 19:23 ` Pedro Alves
2019-02-27 20:19 ` [PATCH v2 13/22] Remove free_current_contents Tom Tromey
2019-03-06 21:34 ` Pedro Alves
2019-02-27 20:19 ` [PATCH v2 03/22] Change displaced_step_clear_cleanup with a forward_scope_exit Tom Tromey
2019-03-06 19:23 ` Pedro Alves
2019-02-27 20:19 ` [PATCH v2 19/22] Make exception throwing a bit more efficient Tom Tromey
2019-04-03 17:04 ` Pedro Alves
2019-02-27 20:19 ` [PATCH v2 09/22] Remove last cleanup from linux-namespaces.c Tom Tromey
2019-03-06 21:07 ` Pedro Alves
2019-02-27 20:19 ` [PATCH v2 06/22] Remove cleanup from solib-svr4.c Tom Tromey
2019-03-06 19:24 ` Pedro Alves
2019-02-27 20:19 ` [PATCH v2 04/22] C++ify remote notification code Tom Tromey
2019-03-06 19:23 ` Pedro Alves [this message]
2019-03-06 21:12 ` Tom Tromey
2019-02-27 20:19 ` [PATCH v2 14/22] Simplify exception handling Tom Tromey
2019-04-02 22:07 ` Pedro Alves
2019-02-27 20:19 ` [PATCH v2 07/22] Remove last cleanups from solib-svr4.c Tom Tromey
2019-03-06 19:32 ` Pedro Alves
2019-03-06 19:39 ` John Baldwin
2019-03-06 21:18 ` Tom Tromey
2019-02-27 20:19 ` [PATCH v2 20/22] Replace throw_exception with throw in some cases Tom Tromey
2019-04-03 17:05 ` Pedro Alves
2019-02-27 20:19 ` [PATCH v2 21/22] Use SCOPE_EXIT in write_gcore_file Tom Tromey
2019-03-06 22:01 ` Pedro Alves
2019-03-06 22:31 ` Tom Tromey
2019-03-06 22:54 ` Pedro Alves
2019-03-06 22:56 ` Tom Tromey
2019-03-06 23:08 ` Tom Tromey
2019-02-27 20:19 ` [PATCH v2 02/22] Update two cleanup comments Tom Tromey
2019-03-06 19:23 ` Pedro Alves
2019-02-27 20:19 ` [PATCH v2 17/22] Rename gdb exception types Tom Tromey
2019-02-27 20:19 ` [PATCH v2 01/22] Remove cleanups from coffread.c Tom Tromey
2019-03-06 19:23 ` Pedro Alves
2019-02-27 20:19 ` [PATCH v2 18/22] Remove some now-dead exception code Tom Tromey
2019-04-03 17:04 ` Pedro Alves
2019-02-27 20:19 ` [PATCH v2 11/22] Use unique_xmalloc_ptr in remote.c Tom Tromey
2019-03-06 21:17 ` Pedro Alves
2019-02-27 20:19 ` [PATCH v2 10/22] Remove last cleanups from stabsread.c Tom Tromey
2019-03-06 21:14 ` Pedro Alves
2019-02-27 20:19 ` [PATCH v2 16/22] Rewrite TRY/CATCH Tom Tromey
2019-04-03 17:03 ` Pedro Alves
2019-04-03 18:02 ` Tom Tromey
2019-02-27 20:19 ` [PATCH v2 15/22] Make exceptions use std::string and be self-managing Tom Tromey
2019-04-03 16:20 ` Pedro Alves
2019-04-03 17:58 ` Tom Tromey
2019-04-03 18:28 ` Pedro Alves
2019-02-27 20:19 ` [PATCH v2 12/22] Remove basic cleanup code Tom Tromey
2019-03-06 21:33 ` Pedro Alves
2019-02-27 20:19 ` [PATCH v2 22/22] Introduce and use bcache_up Tom Tromey
2019-03-06 22:03 ` Pedro Alves
2019-03-07 16:54 ` Tom Tromey
2019-03-07 17:09 ` Pedro Alves
2019-03-07 17:42 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f911dfb-3018-33b0-fbb1-48ece1607c1e@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox