From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15466 invoked by alias); 6 Mar 2019 22:54:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15454 invoked by uid 89); 6 Mar 2019 22:54:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=HX-Spam-Relays-External:2001, tonight, super X-HELO: mail-wr1-f65.google.com Received: from mail-wr1-f65.google.com (HELO mail-wr1-f65.google.com) (209.85.221.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 06 Mar 2019 22:54:05 +0000 Received: by mail-wr1-f65.google.com with SMTP id t18so15275531wrx.2 for ; Wed, 06 Mar 2019 14:54:05 -0800 (PST) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:4c97:6d52:2cea:997b? ([2001:8a0:f913:f700:4c97:6d52:2cea:997b]) by smtp.gmail.com with ESMTPSA id n189sm3675926wmb.28.2019.03.06.14.54.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Mar 2019 14:54:02 -0800 (PST) Subject: Re: [PATCH v2 21/22] Use SCOPE_EXIT in write_gcore_file To: Tom Tromey References: <20190227201849.32210-1-tom@tromey.com> <20190227201849.32210-22-tom@tromey.com> <87bm2nljnr.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Wed, 06 Mar 2019 22:54:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <87bm2nljnr.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-03/txt/msg00134.txt.bz2 -- Thanks, Pedro Alves On 03/06/2019 10:31 PM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> You could rebase this on current master and push it in, to get it > Pedro> out of the way. > > Unless there's a need, I'd rather leave it as-is, since rebasing it > earlier means tweaking other patches earlier in the series. The only tweak othe other patches would need would be to not touch the file at all. This patch eliminates the need for any of the previous changes to the same code. > > Pedro> You could also merge patches #1-#13, the cleanup-elimination patches > Pedro> until the TRY/CATCH parts. I'll need a bit more time to comment > Pedro> on those TRY/CATCH parts, so I've skipped them tonight. > > I don't mind waiting, it's not a super rush to get this in. > Thanks for looking through these. I'd think getting the cleanups elimination patches in would be good for the fact that it makes it impossible for anyone else to end up adding new cleanups meanwhile. And, it makes the remainder patches a smaller self-contained series; any new repost would be much smaller. Thanks, Pedro Alves