Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "andrzej zaborowski" <balrog@zabor.org>
To: gdb-patches@sources.redhat.com
Subject: [PATCH] interpreter-exec error path
Date: Mon, 11 Sep 2006 00:48:00 -0000	[thread overview]
Message-ID: <fb249edb0609101748r7378765et1a338125b0168865@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 430 bytes --]

If any of the commands executed through "interpreter-exec" fails, the
"quiet" value is not restored for the interpreter.  This may result in
something like the following.

(gdb) interpreter-exec console rubbish
Undefined command: "rubbish".  Try "help".
error in command: "rubbish".

readline: readline_callback_read_char() called with no handler!
Aborted

The attached patch will handle the error more correctly.
-- 
balrog 2oo6

[-- Attachment #2: gdb-interpreter-exec.patch --]
[-- Type: application/octet-stream, Size: 584 bytes --]

2006-09-09  Andrzej Zaborowski  <balrog@zabor.org>
	* interps.c (interpreter_exec_cmd): Restore interpreter properties.

--- gdb-orig/gdb/interps.c	2006-09-08 06:10:15.000000000 +0000
+++ gdb/gdb/interps.c	2006-09-08 06:04:20.000000000 +0000
@@ -402,9 +402,9 @@ interpreter_exec_cmd (char *args, int fr
       if (e.reason < 0)
 	{
 	  interp_set (old_interp);
-	  interp_set_quiet (interp_to_use, old_quiet);
+	  interp_set_quiet (interp_to_use, use_quiet);
+	  interp_set_quiet (old_interp, old_quiet);
 	  error (_("error in command: \"%s\"."), prules[i]);
-	  break;
 	}
     }
 

             reply	other threads:[~2006-09-11  0:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-11  0:48 andrzej zaborowski [this message]
2006-09-16  4:12 ` Daniel Jacobowitz
2006-09-11 22:10 Nick Roberts
2006-09-16  4:09 ` Daniel Jacobowitz
2006-09-16  9:36   ` Nick Roberts
2006-11-17 21:17     ` Daniel Jacobowitz
2006-11-17 22:39       ` Nick Roberts
2006-11-17 22:46         ` Daniel Jacobowitz
2006-11-17 22:49           ` Nick Roberts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fb249edb0609101748r7378765et1a338125b0168865@mail.gmail.com \
    --to=balrog@zabor.org \
    --cc=balrogg@gmail.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox