From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16450 invoked by alias); 11 Sep 2006 00:48:39 -0000 Received: (qmail 16437 invoked by uid 22791); 11 Sep 2006 00:48:38 -0000 X-Spam-Check-By: sourceware.org Received: from wx-out-0506.google.com (HELO wx-out-0506.google.com) (66.249.82.238) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 11 Sep 2006 00:48:36 +0000 Received: by wx-out-0506.google.com with SMTP id h28so1370112wxd for ; Sun, 10 Sep 2006 17:48:34 -0700 (PDT) Received: by 10.70.52.1 with SMTP id z1mr5002504wxz; Sun, 10 Sep 2006 17:48:33 -0700 (PDT) Received: by 10.70.33.4 with HTTP; Sun, 10 Sep 2006 17:48:33 -0700 (PDT) Message-ID: Date: Mon, 11 Sep 2006 00:48:00 -0000 From: "andrzej zaborowski" Reply-To: balrogg@gmail.com To: gdb-patches@sources.redhat.com Subject: [PATCH] interpreter-exec error path MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_256337_9524676.1157935713712" X-Google-Sender-Auth: 6b6c329156a7c6af Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-09/txt/msg00050.txt.bz2 ------=_Part_256337_9524676.1157935713712 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline Content-length: 430 If any of the commands executed through "interpreter-exec" fails, the "quiet" value is not restored for the interpreter. This may result in something like the following. (gdb) interpreter-exec console rubbish Undefined command: "rubbish". Try "help". error in command: "rubbish". readline: readline_callback_read_char() called with no handler! Aborted The attached patch will handle the error more correctly. -- balrog 2oo6 ------=_Part_256337_9524676.1157935713712 Content-Type: application/octet-stream; name=gdb-interpreter-exec.patch Content-Transfer-Encoding: base64 X-Attachment-Id: f_ery9a3a8 Content-Disposition: attachment; filename="gdb-interpreter-exec.patch" Content-length: 793 MjAwNi0wOS0wOSAgQW5kcnplaiBaYWJvcm93c2tpICA8YmFscm9nQHphYm9y Lm9yZz4KCSogaW50ZXJwcy5jIChpbnRlcnByZXRlcl9leGVjX2NtZCk6IFJl c3RvcmUgaW50ZXJwcmV0ZXIgcHJvcGVydGllcy4KCi0tLSBnZGItb3JpZy9n ZGIvaW50ZXJwcy5jCTIwMDYtMDktMDggMDY6MTA6MTUuMDAwMDAwMDAwICsw MDAwCisrKyBnZGIvZ2RiL2ludGVycHMuYwkyMDA2LTA5LTA4IDA2OjA0OjIw LjAwMDAwMDAwMCArMDAwMApAQCAtNDAyLDkgKzQwMiw5IEBAIGludGVycHJl dGVyX2V4ZWNfY21kIChjaGFyICphcmdzLCBpbnQgZnIKICAgICAgIGlmIChl LnJlYXNvbiA8IDApCiAJewogCSAgaW50ZXJwX3NldCAob2xkX2ludGVycCk7 Ci0JICBpbnRlcnBfc2V0X3F1aWV0IChpbnRlcnBfdG9fdXNlLCBvbGRfcXVp ZXQpOworCSAgaW50ZXJwX3NldF9xdWlldCAoaW50ZXJwX3RvX3VzZSwgdXNl X3F1aWV0KTsKKwkgIGludGVycF9zZXRfcXVpZXQgKG9sZF9pbnRlcnAsIG9s ZF9xdWlldCk7CiAJICBlcnJvciAoXygiZXJyb3IgaW4gY29tbWFuZDogXCIl c1wiLiIpLCBwcnVsZXNbaV0pOwotCSAgYnJlYWs7CiAJfQogICAgIH0KIAo= ------=_Part_256337_9524676.1157935713712--