Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Nick Roberts <nickrob@snap.net.nz>
To: Daniel Jacobowitz <drow@false.org>
Cc: andrzej zaborowski <balrog@zabor.org>, 	gdb-patches@sources.redhat.com
Subject: Re: [PATCH] interpreter-exec error path
Date: Sat, 16 Sep 2006 09:36:00 -0000	[thread overview]
Message-ID: <17675.50442.412240.290782@kahikatea.snap.net.nz> (raw)
In-Reply-To: <20060916040928.GC7673@nevyn.them.org>

 > > Yes, I think this does what Andrew Cagney intended but the underlying
 > > interpreter has already signalled the exception so I think it could be
 > > handled normally:
 > 
 > There's a FIXME saying that the underlying interpreter shouldn't do
 > this, if I understand your suggestion properly:
 > 
 >   /* FIXME: cagney/2005-01-13: This shouldn't be needed.  Instead the
 >      caller should print the exception.  */
 >   exception_print (gdb_stderr, e);
 >
 > > Taking things a step further, I see that mi_interpreter_exec always
 > > returns exception_none so cli_interpreter_exec could do the same (patch
 > > below).  The command interpreter-exec can handle a list of commands, this
 > > would mean if the first fails, GDB will still handle the subsequent
 > > commands.  This is currently true for mi e.g
 > 
 > And indeed, this makes me ask why this would be a desirable feature. 

It's like make and "make -k" but I guess the former is the preferred/default
behaviour.

 > We stop executing a CLI script if one command fails; I think the same
 > should apply here?

OK, I'll do that if you're agreeable and remove exception_print so each error
only gets reported once.

-- 
Nick                                           http://www.inet.net.nz/~nickrob


  reply	other threads:[~2006-09-16  9:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-11 22:10 Nick Roberts
2006-09-16  4:09 ` Daniel Jacobowitz
2006-09-16  9:36   ` Nick Roberts [this message]
2006-11-17 21:17     ` Daniel Jacobowitz
2006-11-17 22:39       ` Nick Roberts
2006-11-17 22:46         ` Daniel Jacobowitz
2006-11-17 22:49           ` Nick Roberts
  -- strict thread matches above, loose matches on Subject: below --
2006-09-11  0:48 andrzej zaborowski
2006-09-16  4:12 ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17675.50442.412240.290782@kahikatea.snap.net.nz \
    --to=nickrob@snap.net.nz \
    --cc=balrog@zabor.org \
    --cc=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox