Re: [PATCH 2/2] gdb/dwarf: skip broken .debug_macro.dwo

[Simon Marchi <simon.marchi@efficios.com>]

On 5/12/25 1:55 PM, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
> 
> Simon> +		  complaint (_("Multiple .debug_macro.dwo sections found in "
> Simon> +			       "%s, ignoring them."), dwo_file.dbfd->filename);
> 
> complaints are only really visible to gdb developers, since most users
> don't (and shouldn't) enable them.
> 
> However this is a situation where the issue could cause a user-relevant
> problem (macros not working) and has a fix the user could perhaps enact
> (different compiler).  So maybe a warning would be more appropriate?

This would be fine with me.  The line would become:

		  warning (_("Multiple .debug_macro.dwo sections found in "
			     "%s, ignoring them."), dwo_file.dbfd->filename);

The output looks like this:

    (gdb) b main
    During symbol reading: Multiple .debug_macro.dwo sections found in /home/smarchi/build/binutils-gdb/gdb/test.dwo, ignoring them.
    Breakpoint 1 at 0x11b2: file test.cpp, line 4.

Is the patch ok with that change?

Simon