From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] gdb/dwarf: move loops into locate_dw{o,z}_sections
Date: Mon, 12 May 2025 11:52:45 -0600 [thread overview]
Message-ID: <87ikm590nm.fsf@tromey.com> (raw)
In-Reply-To: <20250506170406.124741-1-simon.marchi@efficios.com> (Simon Marchi's message of "Tue, 6 May 2025 13:03:46 -0400")
>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
Simon> For a subsequent patch, it would be easier if the loop over sections
Simon> inside locate_dwo_sections (I want to maintain some state for the
Simon> duration of the loop). Move the for loop in there. And because
Simon> locate_dwz_sections is very similar, modify that one too, to keep both
Simon> in sync.
Looks good, thanks.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
prev parent reply other threads:[~2025-05-12 17:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 17:03 Simon Marchi
2025-05-06 17:03 ` [PATCH 2/2] gdb/dwarf: skip broken .debug_macro.dwo Simon Marchi
2025-05-12 17:55 ` Tom Tromey
2025-05-12 18:08 ` Simon Marchi
2025-05-12 18:48 ` Tom Tromey
2025-05-12 18:50 ` Simon Marchi
2025-05-12 21:06 ` Tom Tromey
2025-05-12 17:52 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ikm590nm.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox