From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id wXEwMpw1ImivNiAAWB0awg (envelope-from ) for ; Mon, 12 May 2025 13:53:32 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=t9tUk8nD; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B1D3D1E10E; Mon, 12 May 2025 13:53:32 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-8.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 176791E089 for ; Mon, 12 May 2025 13:53:32 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B2E593858D20 for ; Mon, 12 May 2025 17:53:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B2E593858D20 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=t9tUk8nD Received: from omta034.useast.a.cloudfilter.net (omta034.useast.a.cloudfilter.net [44.202.169.33]) by sourceware.org (Postfix) with ESMTPS id DDCBA3858C54 for ; Mon, 12 May 2025 17:52:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DDCBA3858C54 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DDCBA3858C54 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1747072376; cv=none; b=MKhYK+V+rlXi9/3SD+qRtYemxqz7IQO17fmMZRnQgJpjsKBJ3injluJ489lFCBKvaLcDL4BMYrmTr5DjWzsVdQM1vosUdC9g+9xNyZxn7lRPN3n9mJsQyY/U/hNLapiNghbU7PPhUFedYiDN3rKYyduH6234YI7tfETeBy5FGWw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1747072376; c=relaxed/simple; bh=gH9Lc+DwDoe0PocsseVTEnegQEJiM5J2l2BbyyPHvLw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=IgHGaLU4BWpTm25y3nSL5/Ra6OImLaTkbawhdCc7DYsdFuK0hFtmhIgSmn/aPjPWGjDzrQwD0dCpLqtR2hNSw4uG6Ax0O8OfkGdIFlFNJtqJflh0rXkeIh8UvnYziy1tshH+uanotFJ7LPiqTk3CMRXxUR6wW7cAP3b1EIlXdoo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DDCBA3858C54 Received: from eig-obgw-5007a.ext.cloudfilter.net ([10.0.29.141]) by cmsmtp with ESMTPS id ETkkunwIcXshwEXKhujQi9; Mon, 12 May 2025 17:52:55 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id EXKguJQkfquerEXKhuF8XZ; Mon, 12 May 2025 17:52:55 +0000 X-Authority-Analysis: v=2.4 cv=KLxcDkFo c=1 sm=1 tr=0 ts=68223577 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dt9VzEwgFbYA:10 a=ItBw4LHWJt0A:10 a=7d_E57ReAAAA:8 a=zstS-IiYAAAA:8 a=1MzrcZI82qaRP7yd3tIA:9 a=jhqOcbufqs7Y1TYCrUUU:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=6Ogn3jAGHLSNbaov7Orx:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=piEmN667DwYMZJsxdIRPOTuMEFE1g+N4FGP3dzL0BsI=; b=t9tUk8nDycVHL6Ce6yddJTRDmu rdioP15S4vVzvBxgAFvYbyneRj45yC6SSwDi14OKzDAzlorfl3aQMyxtBDR0gJ0r2e/5ZmCCpiIMc A3cTzSW4wrNv7R1KoRmKwky1u; Received: from 97-118-46-156.hlrn.qwest.net ([97.118.46.156]:34480 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1uEXKg-00000000F3c-1VNJ; Mon, 12 May 2025 11:52:54 -0600 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] gdb/dwarf: move loops into locate_dw{o,z}_sections In-Reply-To: <20250506170406.124741-1-simon.marchi@efficios.com> (Simon Marchi's message of "Tue, 6 May 2025 13:03:46 -0400") References: <20250506170406.124741-1-simon.marchi@efficios.com> X-Attribution: Tom Date: Mon, 12 May 2025 11:52:45 -0600 Message-ID: <87ikm590nm.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.46.156 X-Source-L: No X-Exim-ID: 1uEXKg-00000000F3c-1VNJ X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-46-156.hlrn.qwest.net (bapiya) [97.118.46.156]:34480 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfOFNL/pbRy405D2rsRjwIrh75Y0HwJzgo4KSsJC8WrIUn7u/VOPQ1o6IJIHa35cneusw+S/LYK2bHuYv7VInW4ww1pZNdAuwfc/YliM1PGbaoO7CoMaE c5iVGFu8CjxWHQusyqBIiQc9U1Nm6t7eAIBx1ZWPBbKUVZRDYFKG/BBu7ZaiwFYHd1h0U4bafWtsnRtU4wizEgKHlH20xtMF5xo= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> For a subsequent patch, it would be easier if the loop over sections Simon> inside locate_dwo_sections (I want to maintain some state for the Simon> duration of the loop). Move the for loop in there. And because Simon> locate_dwz_sections is very similar, modify that one too, to keep both Simon> in sync. Looks good, thanks. Approved-By: Tom Tromey Tom