From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id EM5dKFM5Img6OyAAWB0awg (envelope-from ) for ; Mon, 12 May 2025 14:09:23 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=Ek4A3pmx; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8ABF51E10E; Mon, 12 May 2025 14:09:23 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 93C371E089 for ; Mon, 12 May 2025 14:09:22 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4445E3858D29 for ; Mon, 12 May 2025 18:09:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4445E3858D29 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=Ek4A3pmx Received: from YT6PR01CU002.outbound.protection.outlook.com (mail-canadacentralazlp170120003.outbound.protection.outlook.com [IPv6:2a01:111:f403:c103::3]) by sourceware.org (Postfix) with ESMTPS id 4D5323858D20 for ; Mon, 12 May 2025 18:08:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4D5323858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4D5323858D20 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c103::3 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1747073323; cv=pass; b=p6/edFrJFrioybrPnLqLnsC4+FM7zh/c9uiMhZS3CcoakKB9qMmZK9dp2l9uf2s8oSCxD+hnzvAupXzJoUAU0PToJlk0IXT3ukpX7Wi8mZc8SkNBlVMC8UJ9O8FKivVF0kRsGXK4c5S1DZ3aQ8Wa/z5z0oGtbUws4KVsS/kvdQA= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1747073323; c=relaxed/simple; bh=YlXEfm8TUvwSfFPrxJqCsjBwnS1U8UusxiD1wpAWl1k=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=a12Teb1o5Xo/zEzHpgoAJCiFPH10raqmOg6HBiyRGJCdg+O5FmI+wH61pG2sz1JqWRy8g16psZ4GFV0F7V2Npb5UwwJNEOqfXiqKJ3mRg0wTTNEThQZIcOxcRYfqZneXhxX11EjMlnX5FypIH5DYDJCXLWCxDmcpOi7bD7id3R0= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4D5323858D20 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=SteqnHPtAL6/FLPV5xr3IXLurW01rEjgRdInwocXsCZOswydAzGJpsF2Et0olgsCNswmBZFO0VaKAvdZiMDCrbrZX4/e1XOHKSXMONPxRBgbYvgUHnlLe9d9CFFAHoyMiI5w71DWper6SEt0ptc9ikUqOqNwWNnmhcaiK5J7SrMFqNr1dp4D8Tn8ldVPV47eQtoagGqIuhyKPCzidxXoR1zoWDQdiA0Dozw7U4yl+ZLua/TtFYczKjrvvRVW9d+PWd5lUWl46d9xyEbgdv07XcGE/KIAiF/YtgtArCkkYsBS5TPXTL4W1hEcKE+3o9bzEPOpqz2CwntzexY/T2qojg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xgc0Fu6aDec9LrI+z5Ettpwiknl39O3UqqyCyaOc6Rw=; b=UooEQ5slxiGyfjhEQqnI8OnoKJpzv+G5DvImfhROGKYqzNc9tEF+KWR7zdvnuwF06wNRpWlG8Jf9lHAIh90ZHYf4OIVlnnEOelvX0TlH+9+tme7iUFoALkToLh5yrAKrBL21igL4fGpj565EcZvuhqNsc7KSi1OhI4ufHws3ssab5zqEBResnc3oU9If4CZzKrfljMRkPqUSbRDu+l5mbIdjhctmMJ7GHS8LTWSpvf5fgKxYGkwt0BRzDy9ryz9ymQK94qC2c1gPu7MXWdj+fm0NmPB5SYFyGG1LntJ1xx1Ayn7fyCsun+PzoveFTaVcTl3U1XMr6QdS4WmlLcWMOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xgc0Fu6aDec9LrI+z5Ettpwiknl39O3UqqyCyaOc6Rw=; b=Ek4A3pmxF6snprJskmqslPOv83VLkiTnlEZ2iiXQ3xh1dyl5hCGZ9OfCBDSFNKjwzVkaqorRlOsGDGXeKFy0SFwF5U88HFHDRNWB0gxA3gF5/g9zkW2TWcHxN2yQnKcFW/C+m1ywiLvCwcC5Y96rGOnb8yCerLr2TnPNUXdq6hxlQV/XgTdVQJfZ44K2J4rPGxQEgmuGOZd0rWGh95IVrTaxuGu1FgbSNfBPF0q4bTe9G7+dEsNFAw81QAAGoIsdX/AhSqRvH13orW7n2Y9Lbuzf8rNMiVkFlfagIl9AxFdaeYZRobionp0jnN1wTOIqSKHug4LWKgHB0WQcBJ33JA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from TO1PPF18EA7E37A.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b08::618) by YT3PR01MB10591.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:f9::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8722.30; Mon, 12 May 2025 18:08:38 +0000 Received: from TO1PPF18EA7E37A.CANPRD01.PROD.OUTLOOK.COM ([fe80::d255:2adf:864b:1206]) by TO1PPF18EA7E37A.CANPRD01.PROD.OUTLOOK.COM ([fe80::d255:2adf:864b:1206%4]) with mapi id 15.20.8722.027; Mon, 12 May 2025 18:08:38 +0000 Message-ID: Date: Mon, 12 May 2025 14:08:37 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] gdb/dwarf: skip broken .debug_macro.dwo To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20250506170406.124741-1-simon.marchi@efficios.com> <20250506170406.124741-2-simon.marchi@efficios.com> <87ecwt90id.fsf@tromey.com> Content-Language: fr From: Simon Marchi In-Reply-To: <87ecwt90id.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YT4P288CA0009.CANP288.PROD.OUTLOOK.COM (2603:10b6:b01:d4::14) To TO1PPF18EA7E37A.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b08::618) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TO1PPF18EA7E37A:EE_|YT3PR01MB10591:EE_ X-MS-Office365-Filtering-Correlation-Id: 24867043-b0f5-476a-cfad-08dd91800509 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?aTh2eXdrOXp4S1Foenl0SG5RY0xKZzMwd3JZSHY1Q2t0K1RFYlZRTWdRaGEz?= =?utf-8?B?OXFFWDZhZ0w2NDlVbjdCWW9hQllkNHJScDhWMVN0UStkcDh3YnZ4VkJMOTFu?= =?utf-8?B?dFY4bGZXK0FoMlRZL2U0L3RJMERjYkQ5UUp5dzZFVGZ5M0ZlbmpIbkJPS3Ez?= =?utf-8?B?TEp0cTNpRWtXV3V2ejZNTTRhQmxTS0VJSnBOWFRlRFRwcjBtTk5XNFkydy95?= =?utf-8?B?WXpEdGt2cjRMZ1ArSGNvYzRrUEJJL1k4SkJBbEx5bmNIazJITkt1QllJZVpM?= =?utf-8?B?cm1vSVR5S3gvOUdNN3Y4Mk84d3BNdFd6aVdIc1k5UkN3T3NsandPN2pxb3NH?= =?utf-8?B?UlJkYk9tb0crbUEzZ0N3OVExODhZdk0zTDhiQWpqcFViUEdITFhNYzBweERY?= =?utf-8?B?NWExWVBLbEplczJOSHljVHN4OHloaEhsSzg2Z1BCVTVBdzFNV2oxU1ZqQXUv?= =?utf-8?B?emJVNHNuejVJVVpoMUZoT1lhOWNLVW10ZXllam9LajgrNlFOZHRFd2ZEUDl6?= =?utf-8?B?ZUpqS3l5VE45MkEwUG5LbFhzTjZOOEw3MXMyWkcvb1c3dTNIYXVBeTNBZmhD?= =?utf-8?B?RXRvN3VxVFlxeW1sOUQxandRM04yL1BHZmRDcGtwQmhYd2FaanBDUG9xemJT?= =?utf-8?B?R1gzUlM1cGJyRVZTNm44bXJFSjdJTUhhU05PYUhPTzlQZDFDL1owOHVUQTQ1?= =?utf-8?B?YlB6bTNoRGRzcHFEWnpyMHBIQ3RlMUVIVk1La3Z3R0ZpMWVsS0ZDQ3pneGlj?= =?utf-8?B?RGtiVTNGL1dibzNpYWk0TFE0R1BXRWVYQ0pqc1ZwZGhvRENxVWJQT0UwdEph?= =?utf-8?B?V1NZRnI1bGVSa0tZLzlGUDJSVGNPTm1yRUNCWGMvaEV6NkJENTU2akl6VWNW?= =?utf-8?B?WERpV1loRk9IV0V2eXZUT0ZJY21ieTZaMnhlRjdRclRmdHlVVkZvdDVYNGhO?= =?utf-8?B?T2tCUjBTR0tZRTUxbFBRYmZuRzE4RTM2bjcwbTQ4ZUd5MFVjQjh5TGt5dGNP?= =?utf-8?B?L3ozek03aEEwcjVqcGlpeGU3WXhGcmdOWG9Pd1d6R0MyZDVSc3oxWUtsTm1T?= =?utf-8?B?N2hhemdCaDdrem9LVHpyOE0xVzhKdnFtKzhIUGJvOTBXd3h3dFNwNkpuM3Fa?= =?utf-8?B?SzFxOVE2TGd4Ym5VSHR1aEpiOG5FZFRLNStZT2ZyV3Vra1pkaS9nOFV6dU53?= =?utf-8?B?d2t5ZWRqRUhyR1lCVkNwRm9JaC9VUnhuZEIxYTdyWmhDWDBpV3NqMkJBaDM4?= =?utf-8?B?WlZWa0ZUOGhqK0VNQ1VtWjNZY2h3RzZvTHJhMzJrK1lhYTcrbVFLSWhpWjhM?= =?utf-8?B?bjNEYUNHN1lvQ2lrOG1uMndZMldTZUwwU0ExTlV3NHVyYUVralBGaGx4blp2?= =?utf-8?B?bkNQNHMvY0syNkptQm9uZVVMNjROeVhsK1BKbXgwbmVHcVBEb0R4NWVnSDJu?= =?utf-8?B?UmtqeEZBS3Jyd0xrWldYWkR1cDV4aDVRTTRNUGQrbDRBazREcTVNclo3NWN2?= =?utf-8?B?V2l1TkNqeTF4ekVqOS8zeXhCQUhHRy9rZ05oaXN6RUtoUGFZd1V2SlF3T1Fi?= =?utf-8?B?WXFwZlhIN0RmbS9DQ0RnZjRDTys0M3FqUDRBaWdGQ3dOODBEUzJqUHRveS94?= =?utf-8?B?ZnZJOExUbjNvQ1RyVS9qSDI1ZE9MOWx0bTRwU2V6RWRKcjdyTjdiNGlWMkkv?= =?utf-8?B?NWw0bm1PVnhKZkhiSHFTbXQyYkE0T2JWcUpxbDREcmhSNXdxRXorZDFOaDBF?= =?utf-8?B?M2FRNm8rbDN2TDcwNldyc2JNMVB0TW1jN2phRjM0cmZibGZUb3dGWXYwSUg1?= =?utf-8?B?bGdnRGZYZEFQTkJ4cEZIVjJpR2RIYkg3S052TEl2RGEyNkVXd3N3bjVHMzlt?= =?utf-8?B?dkl0M0ZJNjFBU1RBRmhKMkl1OTJYamVnUzEvellXZWc4bFhVbEZZWS9LR1RE?= =?utf-8?Q?oaPE+T37Qxg=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TO1PPF18EA7E37A.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZVZQR1RDS3grcTk1MlB0RTc5ZHZBSTFGNW1vUWpTbGZWem13TmR0RndYVSsz?= =?utf-8?B?emJaK2pLSUJLc1RJNkJGVmxLUVJmQmxLN295MkhNa0trei9Ea2swSmwycm12?= =?utf-8?B?YS91VTVFWkR2a0E4WWhSczZmdlkzdU44enBiMERRL05teWZ4TFlDV3N0dmov?= =?utf-8?B?cytNUCtwV2hiMEFMY3Z6c2Z1L3F2UnpEZmd6ZDN0SU4wMi8vTlJpdlJjYWFi?= =?utf-8?B?VWxSY05ra3pHME9XQy9ENFBnZGxHbUdTU25BYk1lQXJpYitZRGFhTTJEU3BM?= =?utf-8?B?Q2pVY1g1TjVPYVF3eitqVDM1UHRGTU5xOEdxdE9rK0RXL1pkRVh5VXZWOUZE?= =?utf-8?B?OGFyekdJYi9FSU5hMzZFL0psUFFodGNkclhkbEJ3UG1rcTB2eXVJNzdObkhP?= =?utf-8?B?ejc2UUovaUdyQWRwN1pvZkY4QzFoVit4eEdhWGpHY3JZZm91WURhc2gzV0pX?= =?utf-8?B?b00zdzdWTmFmSVRXYXZOc1YrM0hVTkJEbjZhcDhSaERCNFdtNllZY1BReDJL?= =?utf-8?B?Rnpzb3p0dkEzNFBEeER2N05JT1gwMGhFSmZ6YlNZUnpjMytEbWIrbytQOTIy?= =?utf-8?B?bndHVDVsV3pGcjkyMTNyT0ltWUJkOG1oTmw1YTNBWW1xam00YmNiR0praThh?= =?utf-8?B?aTZyWGY2R0xISkpVNWZjNnhJM3haQW9ZNmtGS01pb1ExcWlqL2p0ZW9oenJY?= =?utf-8?B?YXQwUU8rWFRCS3doQ0FyaXd2dWhoVmpPelFSMjhnYzdqL0xRN1U5c3JTSy9h?= =?utf-8?B?WHRHVVNLMHYyY2k4ZC82OGxtSGZZMCtqbGg2elc1V2UvZURFMEQwNzlDNFBH?= =?utf-8?B?Mm1VcUErc3ByaUFrb2tvYkNwSk96SlRuSjhPK0Zwck92ZlpQSmRzTGFtUDZR?= =?utf-8?B?eFdEODkwcWRtdkM0cmJLVWlQRzVYWFYvTEJmV25hQmgyOUdDa0dGOWtsdW5P?= =?utf-8?B?MjBNSFZ0QzlVZFFwWW5HZGtiUjRNbGFvNEE3bWVtQUg3Nk4vaUxTMnhJd0VF?= =?utf-8?B?bnFxZUFWaDV0a1hTZzc3amwrTVl1VVRoS3BJMlZNcThBV3VFN1FLQzViU1lz?= =?utf-8?B?ZGhpOGZIWjVUMTJiMXFsK0Q4Mkw5NFE3bFQwZk5YZHlFMEpNYmZVZjNPZ1hi?= =?utf-8?B?MStGU2hkK011dit1SnlINi9HS1hES2NxVXpqM1l2eDVDT21OSjAyemY2VVBz?= =?utf-8?B?THVPOUdLNTRQL3FBVmxFZ0lOQWJHd21XQ2JWdmpLTUFjUGhKbjYvNjVjd1FT?= =?utf-8?B?YkpYclFxOEY3ckY3K2U1TUdlS2FkQWxQZys4MVptVUN1cnU2RTNPZHJMZVNm?= =?utf-8?B?Qm1UWDVyN01yWGpmaEo0MGV5Smp6MHg2em1pd1IrU1NqTGxYc0NRYk94MGNN?= =?utf-8?B?bms4LzUyb0ppMlNyZTNVNG9oSVZ6RFg3aHFudXFNY0tDVEZSeFQwQkRlNHBQ?= =?utf-8?B?TFdZbFNVZFgwWWVrMzd3OXZHYVNNdVFFby93RXcwamRhQzF4NGpibVo0eXpj?= =?utf-8?B?aXExR0k0cDBSVDYzQ3BBK1hwMUtBaGRub1pDaUtvUnRCS29UQ01qUEhCSFFB?= =?utf-8?B?ZlpCTjV3SWRFNUFpWHppb3h2WkxRVmJZaFN0aE9zR0NhSURNUXYyVitqMSt5?= =?utf-8?B?MG5STGwyNEJwU3ZtNW5VWXREeENkV0Qxd2RXNW9WTWxPSFhsRHY5bk4vOUVi?= =?utf-8?B?akpUZnRDWFdnNXBKYVNoY3RQVGZ6Nm9mdGtxL0U1cU94QyttQzVGSlE2Z0hm?= =?utf-8?B?UHA4YTNhcWNBNmx1U3IxYzBKaHVxWlNLZ1Voem1ZR3QzSndLaEZONHBIcyth?= =?utf-8?B?T2I0UGlUSGtlRnluSVBhUmp4OGRGV2dGMlpLOTNqMG1RWUpkaCtNZzFodUsv?= =?utf-8?B?R0ZkcWt1aUpPMWc1RVk4N3BXYjhjZ2ViSmMvRnk1U0NIZFkrY0NJWmF0K2Qv?= =?utf-8?B?NkcycEM0TWg2RzVJMDkyRllLNzJ0YmhRNVppZFhPenV4N3gyU2MraTFjZEU3?= =?utf-8?B?cENwSnBTd3FiRVorY2hYSFNRTEVmMjhvOHJOQitSeGxuWUkxQ0t5clc1RGhB?= =?utf-8?B?MnpNWGpmSnJKVEozem9RR1BNTGltc3h2UmUxTFBRRXJyaGszaFJYMHpHUStU?= =?utf-8?Q?nL9eklsVlWJfuAB0oGZVNDyUB?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 24867043-b0f5-476a-cfad-08dd91800509 X-MS-Exchange-CrossTenant-AuthSource: TO1PPF18EA7E37A.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2025 18:08:38.4698 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: r2wM6PZP1UPTxX3gKD38BL4XTW39X+vb7s5CY+o7IGT/botsJpQacDri/783xekL3DG+dSZkmtUgmZb7RSEIfA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT3PR01MB10591 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 5/12/25 1:55 PM, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> + complaint (_("Multiple .debug_macro.dwo sections found in " > Simon> + "%s, ignoring them."), dwo_file.dbfd->filename); > > complaints are only really visible to gdb developers, since most users > don't (and shouldn't) enable them. > > However this is a situation where the issue could cause a user-relevant > problem (macros not working) and has a fix the user could perhaps enact > (different compiler). So maybe a warning would be more appropriate? This would be fine with me. The line would become: warning (_("Multiple .debug_macro.dwo sections found in " "%s, ignoring them."), dwo_file.dbfd->filename); The output looks like this: (gdb) b main During symbol reading: Multiple .debug_macro.dwo sections found in /home/smarchi/build/binutils-gdb/gdb/test.dwo, ignoring them. Breakpoint 1 at 0x11b2: file test.cpp, line 4. Is the patch ok with that change? Simon