Re: [PATCH v3] Add support for NetBSD threads in sparc-nat.c

[Simon Marchi <simark@simark.ca>]

On 2020-03-17 11:10 a.m., Kamil Rytarowski wrote:
> NetBSD ptrace(2) accepts thread id (LWP) as the 4th argument for threads.
> 
> This file is still shared with other targets that use different 4th argument
> type, that is always unused.
> ---
>  gdb/sparc-nat.c | 30 +++++++++++++++++++++++-------
>  1 file changed, 23 insertions(+), 7 deletions(-)
> 
> diff --git a/gdb/sparc-nat.c b/gdb/sparc-nat.c
> index dff0f521565..be99ebb6789 100644
> --- a/gdb/sparc-nat.c
> +++ b/gdb/sparc-nat.c
> @@ -78,6 +78,17 @@ typedef struct fp_status fpregset_t;
>  #define PTRACE_SETFPREGS PT_SETFPREGS
>  #endif
> 
> +static inline int

Remove the `inline`.

> +gdb_ptrace(int request, pid_t pid, void *addr, struct regcache *regcache)

Space before parenthesis.

> +{
> +#ifdef __NetBSD__
> +  /* Support for NetBSD threads.  */

Could you add a bit more to this comment, for example:

  /* Support for NetBSD threads: unlike most other ptrace implementations, NetBSD
     requires that we pass both the pid and lwp.  */

> +  return ptrace (request, pid, addr, regcache->ptid ().lwp ());
> +#else
> +  return ptrace (request, pid, addr, 0);
> +#endif
> +}

I think it would make more sense to just pass the whole ptid, rather than passing the regcache:

static int
gdb_ptrace (int request, ptid_t ptid, void *addr)
{
#ifdef __NetBSD__
  /* Support for NetBSD threads: unlike most other ptrace implementations, NetBSD
     requires that we pass both the pid and lwp.  */
  return ptrace (request, ptid.pid (), addr, ptid.lwp ());
#else
  int pid = get_ptrace_pid (ptid);
  return ptrace (request, pid, addr, 0);
#endif
}

Simon