From: Kamil Rytarowski <n54@gmx.com>
To: gdb-patches@sourceware.org
Cc: cbiesinger@google.com, simark@simark.ca, Kamil Rytarowski <n54@gmx.com>
Subject: [PATCH v3] Add support for NetBSD threads in sparc-nat.c
Date: Tue, 17 Mar 2020 16:10:48 +0100 [thread overview]
Message-ID: <20200317151048.8728-1-n54@gmx.com> (raw)
In-Reply-To: <20200317094046.713-1-n54@gmx.com>
NetBSD ptrace(2) accepts thread id (LWP) as the 4th argument for threads.
This file is still shared with other targets that use different 4th argument
type, that is always unused.
---
gdb/sparc-nat.c | 30 +++++++++++++++++++++++-------
1 file changed, 23 insertions(+), 7 deletions(-)
diff --git a/gdb/sparc-nat.c b/gdb/sparc-nat.c
index dff0f521565..be99ebb6789 100644
--- a/gdb/sparc-nat.c
+++ b/gdb/sparc-nat.c
@@ -78,6 +78,17 @@ typedef struct fp_status fpregset_t;
#define PTRACE_SETFPREGS PT_SETFPREGS
#endif
+static inline int
+gdb_ptrace(int request, pid_t pid, void *addr, struct regcache *regcache)
+{
+#ifdef __NetBSD__
+ /* Support for NetBSD threads. */
+ return ptrace (request, pid, addr, regcache->ptid ().lwp ());
+#else
+ return ptrace (request, pid, addr, 0);
+#endif
+}
+
/* Register set description. */
const struct sparc_gregmap *sparc_gregmap;
const struct sparc_fpregmap *sparc_fpregmap;
@@ -166,7 +177,8 @@ sparc_fetch_inferior_registers (struct regcache *regcache, int regnum)
{
gregset_t regs;
- if (ptrace (PTRACE_GETREGS, pid, (PTRACE_TYPE_ARG3) ®s, 0) == -1)
+ if (gdb_ptrace (PTRACE_GETREGS, pid,
+ (PTRACE_TYPE_ARG3) ®s, regcache) == -1)
perror_with_name (_("Couldn't get registers"));
sparc_supply_gregset (sparc_gregmap, regcache, -1, ®s);
@@ -178,7 +190,8 @@ sparc_fetch_inferior_registers (struct regcache *regcache, int regnum)
{
fpregset_t fpregs;
- if (ptrace (PTRACE_GETFPREGS, pid, (PTRACE_TYPE_ARG3) &fpregs, 0) == -1)
+ if (gdb_ptrace (PTRACE_GETFPREGS, pid,
+ (PTRACE_TYPE_ARG3) &fpregs, regcache) == -1)
perror_with_name (_("Couldn't get floating point status"));
sparc_supply_fpregset (sparc_fpregmap, regcache, -1, &fpregs);
@@ -199,12 +212,14 @@ sparc_store_inferior_registers (struct regcache *regcache, int regnum)
{
gregset_t regs;
- if (ptrace (PTRACE_GETREGS, pid, (PTRACE_TYPE_ARG3) ®s, 0) == -1)
+ if (gdb_ptrace (PTRACE_GETREGS, pid,
+ (PTRACE_TYPE_ARG3) ®s, regcache) == -1)
perror_with_name (_("Couldn't get registers"));
sparc_collect_gregset (sparc_gregmap, regcache, regnum, ®s);
- if (ptrace (PTRACE_SETREGS, pid, (PTRACE_TYPE_ARG3) ®s, 0) == -1)
+ if (gdb_ptrace (PTRACE_SETREGS, pid,
+ (PTRACE_TYPE_ARG3) ®s, regcache) == -1)
perror_with_name (_("Couldn't write registers"));
/* Deal with the stack regs. */
@@ -225,7 +240,8 @@ sparc_store_inferior_registers (struct regcache *regcache, int regnum)
{
fpregset_t fpregs, saved_fpregs;
- if (ptrace (PTRACE_GETFPREGS, pid, (PTRACE_TYPE_ARG3) &fpregs, 0) == -1)
+ if (gdb_ptrace (PTRACE_GETFPREGS, pid,
+ (PTRACE_TYPE_ARG3) &fpregs, regcache) == -1)
perror_with_name (_("Couldn't get floating-point registers"));
memcpy (&saved_fpregs, &fpregs, sizeof (fpregs));
@@ -237,8 +253,8 @@ sparc_store_inferior_registers (struct regcache *regcache, int regnum)
to write the registers if nothing changed. */
if (memcmp (&saved_fpregs, &fpregs, sizeof (fpregs)) != 0)
{
- if (ptrace (PTRACE_SETFPREGS, pid,
- (PTRACE_TYPE_ARG3) &fpregs, 0) == -1)
+ if (gdb_ptrace (PTRACE_SETFPREGS, pid,
+ (PTRACE_TYPE_ARG3) &fpregs, regcache) == -1)
perror_with_name (_("Couldn't write floating-point registers"));
}
--
2.25.0
next prev parent reply other threads:[~2020-03-17 15:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 9:40 [PATCH] " Kamil Rytarowski
2020-03-17 15:10 ` Kamil Rytarowski [this message]
2020-03-17 16:03 ` [PATCH v3] " Simon Marchi
2020-03-17 16:46 ` [PATCH v4] " Kamil Rytarowski
2020-03-17 16:51 ` Simon Marchi
2020-03-17 16:59 ` Simon Marchi
2020-03-17 17:07 ` Kamil Rytarowski
2020-03-17 17:10 ` Simon Marchi
2020-03-17 18:14 ` Kamil Rytarowski
2020-03-17 18:18 ` [PATCH v5] " Kamil Rytarowski
2020-03-17 19:07 ` Simon Marchi
2020-03-17 19:09 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200317151048.8728-1-n54@gmx.com \
--to=n54@gmx.com \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox