From: Kamil Rytarowski <n54@gmx.com>
To: Simon Marchi <simark@simark.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH v4] Add support for NetBSD threads in sparc-nat.c
Date: Tue, 17 Mar 2020 19:14:37 +0100 [thread overview]
Message-ID: <b7e14568-5af0-49b1-ce25-1d7df02af8f2@gmx.com> (raw)
In-Reply-To: <3329d58a-86cf-1f73-188d-ca2306954354@simark.ca>
[-- Attachment #1.1: Type: text/plain, Size: 791 bytes --]
On 17.03.2020 18:10, Simon Marchi wrote:
> On 2020-03-17 1:07 p.m., Kamil Rytarowski wrote:
>> On 17.03.2020 17:59, Simon Marchi wrote:
>>> I tried to build this using a sparc-linux cross-compiler, and I think we need
>>> to adjust gdb_ptrace to account for the various possible arguments types. The
>>> following version of the function builds fine with sparc64-linux-gnu-gcc, can you
>>> try it with NetBSD?
>>>
>>> static PTRACE_TYPE_RET
>>> gdb_ptrace (PTRACE_TYPE_ARG1 request, ptid_t ptid, PTRACE_TYPE_ARG4 addr)
>>
>> Does it work for you if you use PTRACE_TYPE_ARG3? addr is the 3rd argument.
>>
>> PTRACE_TYPE_ARG4 is int on BSDs.
>
> Err yes sorry, it should be PTRACE_TYPE_ARG3, my bad.
>
> Simon
>
I've tested v5 with the NetBSD/sparc build (32-bit).
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-03-17 18:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 9:40 [PATCH] " Kamil Rytarowski
2020-03-17 15:10 ` [PATCH v3] " Kamil Rytarowski
2020-03-17 16:03 ` Simon Marchi
2020-03-17 16:46 ` [PATCH v4] " Kamil Rytarowski
2020-03-17 16:51 ` Simon Marchi
2020-03-17 16:59 ` Simon Marchi
2020-03-17 17:07 ` Kamil Rytarowski
2020-03-17 17:10 ` Simon Marchi
2020-03-17 18:14 ` Kamil Rytarowski [this message]
2020-03-17 18:18 ` [PATCH v5] " Kamil Rytarowski
2020-03-17 19:07 ` Simon Marchi
2020-03-17 19:09 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7e14568-5af0-49b1-ce25-1d7df02af8f2@gmx.com \
--to=n54@gmx.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox