From: Guinevere Larsen <guinevere@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v5] gdb: Introduce RAII signal handler setter
Date: Fri, 22 Nov 2024 14:50:54 -0300 [thread overview]
Message-ID: <f5be6857-bf5c-4080-abb5-9c2bb386fee3@redhat.com> (raw)
In-Reply-To: <87iksfs1pd.fsf@tromey.com>
On 11/22/24 12:55 PM, Tom Tromey wrote:
>>>>>> "Guinevere" == Guinevere Larsen <guinevere@redhat.com> writes:
> Guinevere> +#if defined (HAVE_SIGACTION)
> Guinevere> + struct sigaction m_prev_handler;
> Guinevere> +#else
> Guinevere> + typedef sighandler_t m_prev_handler;
> Guinevere> +#endif
>
> That #else branch looks wrong, I would guess s/typedef//
gah! thanks, copy-paste issues. will fix
>
> gnulib says sigaction isn't on mingw, so maybe a mingw cross-hosted
> build would show the problem.
I have un-defined the macro and tested. Current version did fail to
build and changing that line has fixed compilation.
--
Cheers,
Guinevere Larsen
She/Her/Hers
>
> Tom
>
next prev parent reply other threads:[~2024-11-22 17:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-18 19:57 Guinevere Larsen
2024-11-22 15:55 ` Tom Tromey
2024-11-22 17:50 ` Guinevere Larsen [this message]
2024-11-22 18:46 ` Tom Tromey
2024-11-22 20:38 ` Guinevere Larsen
2026-04-15 13:10 ` Aktemur, Tankut Baris
2026-04-15 13:16 ` Guinevere Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5be6857-bf5c-4080-abb5-9c2bb386fee3@redhat.com \
--to=guinevere@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox