Re: [PATCH v5] gdb: Introduce RAII signal handler setter

[Guinevere Larsen <guinevere@redhat.com>]

On 4/15/26 10:10 AM, Aktemur, Tankut Baris wrote:
> Hi Guinevere,
>
> On Friday, November 22, 2024 6:51 PM, Guinevere Larsen wrote:
>> On 11/22/24 12:55 PM, Tom Tromey wrote:
>>>>>>>> "Guinevere" == Guinevere Larsen <guinevere@redhat.com> writes:
>>> Guinevere> +#if defined (HAVE_SIGACTION)
>>> Guinevere> +  struct sigaction m_prev_handler;
>>> Guinevere> +#else
>>> Guinevere> +  typedef sighandler_t m_prev_handler;
>>> Guinevere> +#endif
>>>
>>> That #else branch looks wrong, I would guess s/typedef//
>> gah! thanks, copy-paste issues. will fix
>>> gnulib says sigaction isn't on mingw, so maybe a mingw cross-hosted
>>> build would show the problem.
>> I have un-defined the macro and tested.
> Could it be that the local experiment above sneaked into
> gdbsupport/scoped_signal_handler.h?  In that file there is
>
>    #undef HAVE_SIGACTION
>
> which seems to clear the macro unintentionally.
oops, yes, it probably sneaked in. The file definitely was not supposed 
to be unsetting the macro.
>
> Regards,
> -Baris
>
>
> Intel Deutschland GmbH
> Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany
> Tel: +49 89 991 430, www.intel.de
> Managing Directors: Harry Demas, Jeffrey Schneiderman, Yin Chong Sorrell
> Chairperson of the Supervisory Board: Nicole Lau
> Registered Seat: Munich
> Commercial Register: Amtsgericht Muenchen HRB 186928
>

-- 
Cheers,
Guinevere Larsen
It/she